Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiles view should offer link to clear filters #4403

Closed
3 tasks done
jsoref opened this issue Sep 23, 2020 · 1 comment · Fixed by #4622
Closed
3 tasks done

Tiles view should offer link to clear filters #4403

jsoref opened this issue Sep 23, 2020 · 1 comment · Fixed by #4622
Labels
component:ui User interfaces bugs and enhancements enhancement New feature or request

Comments

@jsoref
Copy link
Member

jsoref commented Sep 23, 2020

If you are trying to resolve an environment-specific issue or have a one-off question about the edge case that does not require a feature then please consider asking a
question in argocd slack channel.

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

There should be a clickable link to clear filters in the tiles view as there is in network and tree views.

To Reproduce

  1. Load https://cd.apps.argoproj.io/applications/argo-cd?resource=health%3AUnknown (on average, nothing should be unknown)
  2. In another window, load https://cd.apps.argoproj.io/applications?view=tiles&proj=&sync=Unknown&health=&namespace=&cluster=&labels= (on average, nothing should be unknown)

See:

No resources found
Try to change filter criteria

Expected behavior

Both views should have a handy equivalent way to clear filters

Screenshots

image
image

Version

v1.8.0+fbfa89d

Logs

@jsoref jsoref added the bug Something isn't working label Sep 23, 2020
@alexmt alexmt added component:ui User interfaces bugs and enhancements enhancement New feature or request and removed bug Something isn't working labels Sep 23, 2020
@tetchel
Copy link
Contributor

tetchel commented Sep 28, 2020

The filters are much more obvious when the window is wider.

image

When the window is narrow (as in the original commenter's screenshot), the filters panel collapses into the FILTERS combo-box and the arrow to expand is it not obvious.

I will add a way to 'clear filters' from the 'no applications found' message, and will try to make the expansion arrow more obvious

alexmt pushed a commit that referenced this issue Oct 29, 2020
* feat: Improve UX when filtering applications

- When application filters are active, show a badge with # filters and a button to clear them
- When no matching applications are found, provide a button to clear filters
- Styling updates to application filters UI

Signed-off-by: Tim Etchells <tetchell@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:ui User interfaces bugs and enhancements enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants