Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display List of Git Branches as Drop Down #4645

Closed
rajivml opened this issue Oct 23, 2020 · 8 comments · Fixed by #4713
Closed

Display List of Git Branches as Drop Down #4645

rajivml opened this issue Oct 23, 2020 · 8 comments · Fixed by #4713
Assignees
@tetchel
Labels
component:config-management Tools specific issues (helm, kustomize etc) enhancement New feature or request help wanted Extra attention is needed

Comments

@rajivml
Copy link

rajivml commented Oct 23, 2020 •
edited
Loading

HI,

Summary

Is it possible to display list of all branches under a github repo. Since you guys support both branches and tags may be an additional drop drop where user will select he needs branches or tags , if branches is selected then show list of branches as an other drop and if tags is selected then fetch and show list of tags as drop down

image

Motivation

We are evaluating using argoCD as an deployment option through which our customers can install/upgrade software on varous kubernetes environments. One feedback that has come in, how to customers discover new software releases where release/20.4 is one release and release/20.5 is an other release but how do customers know that from release/20.4 they have to go to release/20.5 without visiting github repo

Thanks
@rajivml rajivml added the enhancement New feature or request label Oct 23, 2020
@tetchel
Copy link
Contributor

tetchel commented Oct 23, 2020

I will pick this up

@alexmt alexmt added the help wanted Extra attention is needed label Oct 23, 2020
@alexmt alexmt added the component:config-management Tools specific issues (helm, kustomize etc) label Oct 23, 2020
@tetchel
Copy link
Contributor

tetchel commented Oct 26, 2020 •
edited
Loading

  1. Is there a use-case for tags here, too? Or are we only interested in branches?

    Obviously I don't want to show every revision, since a list of all commit hashes would not be very useful.

  2. Is there any preference for the order to display the branches in?

  • Most recently updated
  • Lexographic
  • something else?

@tetchel
Copy link
Contributor

tetchel commented Oct 30, 2020

image

I went with HEAD, then branches, then tags. I think a way to toggle "show branches" and "show tags" options would be useful, but I will keep it simpler for now.

@tetchel
Copy link
Contributor

tetchel commented Oct 30, 2020

I added it to the App summary page too.
image

@tetchel tetchel mentioned this issue Oct 30, 2020
Merged
7 tasks
alexmt pushed a commit that referenced this issue Nov 2, 2020
@tetchel
feat: Add autocomplete for repo Revisions (#4645) (#4713)
8603150 
* feat: Add autocomplete for repo Revisions

- Introduces api/v1/repositories/{repo}/refs which returns branches and tags
- Add new RevisionFormField component to Create and Edit Application pages

Signed-off-by: Tim Etchells <tetchell@redhat.com>
terrycorley pushed a commit to terrycorley/argo-cd that referenced this issue Nov 3, 2020
@terry-sm
Merge branch 'master' of github.com:argoproj/argo-cd into add-kustomi…
fed6f94 
…zation-generators

* 'master' of github.com:argoproj/argo-cd:
  fix: RevisionFormField component crashes in 'refs' API returns no tags (argoproj#4735)
  docs: add Opensurvey to USERS.md (argoproj#4727)
  docs: correct parameters usage in CLI (argoproj#4725)
  fix: Repo-server has silent unmarshalling errors leading to empty applications (argoproj#4423) (argoproj#4708)
  fix: inject artificial delay between sync waves to better support health assessments (argoproj#4715)
  fix: exclude files listed under exclusions (argoproj#4686)
  feat: support resource actions on CRDs that use status subresources (argoproj#4690)
  feat: Add autocomplete for repo Revisions (argoproj#4645) (argoproj#4713)
  fix: webhook don't refresh apps pointing to HEAD (argoproj#4717)
  feat: Add support for ExecProvider cluster auth (argoproj#4600) (argoproj#4710)
  fix: adding helm values file in New App (argoproj#4635)
  docs: Instructions on `make verify-kube-connect` step when using k3d (argoproj#4687)
  feat:  Annotation based app paths detection in webhooks (argoproj#4699)
  fix: adding commonAnnotations for Kustomize (argoproj#4613)
@rajivml
Copy link
Author

rajivml commented Nov 4, 2020 •
edited
Loading

@tetchel Thanks for picking this up so quickly, I was on vacation, so I missed your comments....if we can add toggle option as well i.e. tags vs branches defaulting it to branches it will be more helpful as we use both branches and tags

and w.r.t the order in which branches has to be displayed, usually our branches are named like this release/v20.4, release/v20.10 , so release/v20.10 should come first

shall I raise a different ticket for the toggle feature ? BTW in which argoCD version this feature will be available ?

@tetchel tetchel mentioned this issue Nov 4, 2020
Closed
@tetchel
Copy link
Contributor

tetchel commented Nov 4, 2020

Hi Rajiv, I opened a new issue for your request.

I believe this feature will be available in the next argocd release, 1.8. But Alex can confirm

@keithchong keithchong mentioned this issue Nov 6, 2020
Merged
7 tasks
@rajivml
Copy link
Author

rajivml commented Dec 9, 2020

@alexmt can you please confirm which argo version will have this change ? I just now installed argo 1.7.9 and I couldn't see this change

@rajivml
Copy link
Author

rajivml commented Dec 9, 2020

image

Installed 1.8 and I can see this change, thanks a lot for making this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tetchel tetchel

Labels
component:config-management Tools specific issues (helm, kustomize etc) enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add autocomplete for repo Revisions (#4645) tetchel/argo-cd
3 participants
@alexmt @tetchel @rajivml