fix: Repo-server has silent unmarshalling errors leading to empty applications (#4423) #4708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4708 +/- ##
==========================================
+ Coverage 41.07% 41.12% +0.04%
==========================================
Files 127 127
Lines 17404 17451 +47
==========================================
+ Hits 7148 7176 +28
- Misses 9231 9244 +13
- Partials 1025 1031 +6
Continue to review full report at Codecov.
|
jgwest
force-pushed
the
bug-4423-cache-hash
branch
from
3199a5f
to
957f705
Compare
terrycorley
pushed a commit
to terrycorley/argo-cd
that referenced
this pull request
Nov 3, 2020
…zation-generators * 'master' of github.com:argoproj/argo-cd: fix: RevisionFormField component crashes in 'refs' API returns no tags (argoproj#4735) docs: add Opensurvey to USERS.md (argoproj#4727) docs: correct parameters usage in CLI (argoproj#4725) fix: Repo-server has silent unmarshalling errors leading to empty applications (argoproj#4423) (argoproj#4708) fix: inject artificial delay between sync waves to better support health assessments (argoproj#4715) fix: exclude files listed under exclusions (argoproj#4686) feat: support resource actions on CRDs that use status subresources (argoproj#4690) feat: Add autocomplete for repo Revisions (argoproj#4645) (argoproj#4713) fix: webhook don't refresh apps pointing to HEAD (argoproj#4717) feat: Add support for ExecProvider cluster auth (argoproj#4600) (argoproj#4710) fix: adding helm values file in New App (argoproj#4635) docs: Instructions on `make verify-kube-connect` step when using k3d (argoproj#4687) feat: Annotation based app paths detection in webhooks (argoproj#4699) fix: adding commonAnnotations for Kustomize (argoproj#4613)
This was referenced Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a hash of the full contents of
CachedManifestResponse(excluding the hash itself) to what is persisted to Redis for generated manifests. This allows detection of the case where the cache contents are empty or incomplete (as described in the original issue). Hash mismatches are treated as cache misses, so manifest regeneration will occur in these cases.Feedback welcome re: the specific algorithm used (current design: FNV-64a), and whether to hash the full cache entry or just the manifest response (current design: full cache entry).
Parent issue: #4423
Checklist: