Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark mode #4722

Closed
StianOvrevage opened this issue Nov 1, 2020 · 17 comments · Fixed by #9703
Closed

Add dark mode #4722

StianOvrevage opened this issue Nov 1, 2020 · 17 comments · Fixed by #9703
Assignees
Labels
accessibility For improving the accessibility of UI component:ui User interfaces bugs and enhancements enhancement New feature or request

Comments

@StianOvrevage
Copy link

Summary

Add a dark mode to web console.

Motivation

Winter is coming up north and my eyes are hurting.

Proposal

CSS?

@StianOvrevage StianOvrevage added the enhancement New feature or request label Nov 1, 2020
@jessesuen
Copy link
Member

FYI, CSS can already be customized so technically this is already possible.

@tete17
Copy link
Contributor

tete17 commented Nov 27, 2020

Hi @jessesuen I think @StianOvrevage was referring more to a toggle feature where the ui can switch from one state to another at the user wish.

Similar to what Grafana or Kibana offers. Can't promise anything but if you give me a couple of tips on where to find these css's I can maybe help out.

I am asking because I know argo keeps all it's ui components in a different project and I am not sure how the glue between the argo app controller (this repo I presume) and the ui work.

@theNewFlesh
Copy link

+1

@theNewFlesh
Copy link

I've created a stylish theme for ArgoCD with my dark mode style I use for everything.
Check it out here if you want.

@shankiflang
Copy link

+1

3 similar comments
@ernelio
Copy link

ernelio commented Jul 12, 2021

+1

@richardfelkl
Copy link

+1

@matan1811
Copy link

+1

@saumeya
Copy link
Contributor

saumeya commented May 5, 2022

I'll work on this!

@saumeya saumeya added component:ui User interfaces bugs and enhancements accessibility For improving the accessibility of UI labels May 5, 2022
@theNewFlesh
Copy link

@saumeya That stylish theme also applies to Argo Workflows BTW.

@saumeya
Copy link
Contributor

saumeya commented May 5, 2022

Looks pretty cool @theNewFlesh, is it applied to argo using configmap?

@theNewFlesh
Copy link

theNewFlesh commented May 5, 2022

@saumeya
Nope.

Stylish is a browser extension for chrome and brave. It matches URL's based on regex and or domain and injects a custom CSS that overrides the page. That custom CSS is found as a Stylish package on userstyles.org, which is also how you install it.

Essentially, I copy the CSS from the ArgoCD page, replace the color values with my own theme, and paste that CSS into a new stylish package, then upload it to userstyles.org.

@saumeya
Copy link
Contributor

saumeya commented May 6, 2022

Ah, thanks for sharing this info. I'll try it out. I was thinking more from the perspective of having a toggle within the application.

@theNewFlesh
Copy link

Yeah, that would be great. Until then, this is what I use. I recommend you copy the CSS and go from there.

Stylish will disable the theme toggle if the URL of ArgoCD doesn't match what's in the stylish theme settings. So, you will probably have to configure that to some regex and/or domain where you are running Argo. Click Stylish menu icon then [kebab] then edit button of the theme to see the CSS and change the URLs.

@saumeya saumeya mentioned this issue Jun 17, 2022
10 tasks
@saumeya saumeya self-assigned this Sep 7, 2022
crenshaw-dev pushed a commit that referenced this issue Sep 17, 2022
* feat: enable dark theme in ui

Signed-off-by: saumeya <saumeyakatyal@gmail.com>

* add more theme styles

Signed-off-by: saumeya <saumeyakatyal@gmail.com>

* remove package lock

Signed-off-by: saumeya <saumeyakatyal@gmail.com>

* improvements

Signed-off-by: saumeya <saumeyakatyal@gmail.com>

* improvements

Signed-off-by: saumeya <saumeyakatyal@gmail.com>

* cleanup

Signed-off-by: saumeya <saumeyakatyal@gmail.com>

* fix review comments

Signed-off-by: saumeya <saumeyakatyal@gmail.com>

* update argo-ui sha

Signed-off-by: saumeya <saumeyakatyal@gmail.com>

* update moment yarn.lock

Signed-off-by: saumeya <saumeyakatyal@gmail.com>

update moment yarn.lock

Signed-off-by: saumeya <saumeyakatyal@gmail.com>

update moment yarn.lock

Signed-off-by: saumeya <saumeyakatyal@gmail.com>

* fix review comments

Signed-off-by: saumeya <saumeyakatyal@gmail.com>

Signed-off-by: saumeya <saumeyakatyal@gmail.com>
@sergeyshevch
Copy link

I guess it will be great to automatically detect OS light/dark mode and use it for the theme in ArgoCD. I will very much like such feature. (Github works in similar way)

@crenshaw-dev
Copy link
Collaborator

@sergeyshevch can you open an enhancement request for that?

ashutosh16 pushed a commit to ashutosh16/argo-cd that referenced this issue Oct 7, 2022
* feat: enable dark theme in ui

Signed-off-by: saumeya <saumeyakatyal@gmail.com>

* add more theme styles

Signed-off-by: saumeya <saumeyakatyal@gmail.com>

* remove package lock

Signed-off-by: saumeya <saumeyakatyal@gmail.com>

* improvements

Signed-off-by: saumeya <saumeyakatyal@gmail.com>

* improvements

Signed-off-by: saumeya <saumeyakatyal@gmail.com>

* cleanup

Signed-off-by: saumeya <saumeyakatyal@gmail.com>

* fix review comments

Signed-off-by: saumeya <saumeyakatyal@gmail.com>

* update argo-ui sha

Signed-off-by: saumeya <saumeyakatyal@gmail.com>

* update moment yarn.lock

Signed-off-by: saumeya <saumeyakatyal@gmail.com>

update moment yarn.lock

Signed-off-by: saumeya <saumeyakatyal@gmail.com>

update moment yarn.lock

Signed-off-by: saumeya <saumeyakatyal@gmail.com>

* fix review comments

Signed-off-by: saumeya <saumeyakatyal@gmail.com>

Signed-off-by: saumeya <saumeyakatyal@gmail.com>
@laiminhtrung1997
Copy link

How can I set the dark mode as the default theme when starting the ArgoCD UI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility For improving the accessibility of UI component:ui User interfaces bugs and enhancements enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.