Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add the necessary scaffolding for a dark mode theme #4929

Closed
wants to merge 1 commit into from

Conversation

tete17
Copy link
Contributor

@tete17 tete17 commented Nov 29, 2020

Signed-off-by: tete17 miguel_tete17@hotmail.com
#4722

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I've signed the CLA and my build is green (troubleshooting builds).

Technically this PR doesn't add any new features. It simply adds the necessary scaffolding for the Ui to implement a future dark mode.

I initially intended to submit a complete PR with the complete feature but after discovering the existence of https://github.com/argoproj/argo-ui I realised I would need to make a PR there too. My intention now is to submit this short one first to get some experience on how things run in the argo world and then submit progressive PR to fully implement the dark mode.

I also want to open this soon to know if this is something the argo team really wants, is not something spent the effort or has a specific implementation plan in mind.

I also attach a small gif with the user experience
Peek 29-11-2020 22-00

@CLAassistant
Copy link

CLAassistant commented Nov 29, 2020

CLA assistant check
All committers have signed the CLA.

Signed-off-by: tete17 <miguel_tete17@hotmail.com>
@codecov-io
Copy link

codecov-io commented Nov 29, 2020

Codecov Report

Merging #4929 (94c0724) into master (345c77a) will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4929      +/-   ##
==========================================
- Coverage   41.44%   41.35%   -0.10%     
==========================================
  Files         128      128              
  Lines       17666    17666              
==========================================
- Hits         7322     7305      -17     
- Misses       9292     9313      +21     
+ Partials     1052     1048       -4     
Impacted Files Coverage Δ
controller/appcontroller.go 50.56% <0.00%> (-1.92%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 345c77a...94c0724. Read the comment docs.

@rbreeze
Copy link
Member

rbreeze commented Dec 1, 2020

Are you planning on implementing the completed dark mode feature yourself?

Would you consider opening this PR for another branch (i.e. one called dark-mode? It's unlikely this PR will get merged to master since it's an incomplete feature. Using a separate branch would be more conducive to how you want to develop this.

@tete17 tete17 closed this Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants