feat: Add the necessary scaffolding for a dark mode theme #4929
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tete17 miguel_tete17@hotmail.com
#4722
Checklist:
Technically this PR doesn't add any new features. It simply adds the necessary scaffolding for the Ui to implement a future dark mode.
I initially intended to submit a complete PR with the complete feature but after discovering the existence of https://github.com/argoproj/argo-ui I realised I would need to make a PR there too. My intention now is to submit this short one first to get some experience on how things run in the argo world and then submit progressive PR to fully implement the dark mode.
I also want to open this soon to know if this is something the argo team really wants, is not something spent the effort or has a specific implementation plan in mind.
I also attach a small gif with the user experience