Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GNU make compatibility for plugins #6290

Closed
blakebarnett opened this issue May 21, 2021 · 0 comments · Fixed by #6293
Closed

GNU make compatibility for plugins #6290

blakebarnett opened this issue May 21, 2021 · 0 comments · Fixed by #6293
Labels
enhancement New feature or request

Comments

@blakebarnett
Copy link
Contributor

Summary

GNU make can not deal with colons in filenames (ref: https://lists.gnu.org/archive/html/bug-make/2004-10/msg00010.html)

By default ArgoCD is creating temporary directories with the repo URI in them, which includes colons.

Motivation

Trying to add a plugin for an existing build system which heavily relies on GNU make.

Proposal

Strip additional incompatible characters from the directory names before creating them (it seems this already happens for other characters)
@blakebarnett blakebarnett added the enhancement New feature or request label May 21, 2021
blakebarnett pushed a commit to blakebarnett/argo-cd that referenced this issue May 21, 2021
fix: replace colons in addition to slashes in app tmp directory for g…
a50a87b 
…it client (argoproj#6290)

closes argoproj#6290

Signed-off-by: Blake Barnett <blakeb@me.com>
@blakebarnett blakebarnett mentioned this issue May 21, 2021
Closed
5 tasks
blakebarnett added a commit to blakebarnett/argo-cd that referenced this issue May 21, 2021
@blakebarnett
fix: replace colons in addition to slashes in app tmp directory (argo…
53b918d 
…proj#6290)

closes argoproj#6290

Signed-off-by: Blake Barnett <blakeb@me.com>
@blakebarnett blakebarnett mentioned this issue May 21, 2021
Merged
4 tasks
alexmt pushed a commit that referenced this issue May 24, 2021
@blakebarnett
fix: replace colons in addition to slashes in app tmp directory (#6290)…
ae5388d 
… (#6293)

closes #6290

Signed-off-by: Blake Barnett <blakeb@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@blakebarnett