Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace colons in addition to slashes in app tmp directory (#6290) #6293

Merged

Conversation

blakebarnett
Copy link
Contributor

@blakebarnett blakebarnett commented May 21, 2021

closes #6290

Signed-off-by: Blake Barnett blakeb@me.com

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • [b] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • [N/A] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • [N/A] Does this PR require documentation updates?
  • [N/A] I've updated documentation as required by this PR.
  • [N/A] Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • [N/A] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clear and detailed explanation in #6290 .

LGTM

@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #6293 (53b918d) into master (0e9823e) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6293      +/-   ##
==========================================
- Coverage   41.09%   41.07%   -0.02%     
==========================================
  Files         151      151              
  Lines       19931    19932       +1     
==========================================
- Hits         8190     8188       -2     
- Misses      10612    10614       +2     
- Partials     1129     1130       +1     
Impacted Files Coverage Δ
util/git/client.go 44.28% <0.00%> (-0.16%) ⬇️
util/settings/settings.go 46.75% <0.00%> (-0.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e9823e...53b918d. Read the comment docs.

@alexmt alexmt merged commit ae5388d into argoproj:master May 24, 2021
@jannfis jannfis added the needs-verification PR requires pre-release verification label Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-verification PR requires pre-release verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GNU make compatibility for plugins
3 participants