Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support XDG Base directory standard #7638

Closed
sagikazarmark opened this issue Nov 6, 2021 · 2 comments · Fixed by #7791
Closed

Support XDG Base directory standard #7638

sagikazarmark opened this issue Nov 6, 2021 · 2 comments · Fixed by #7791
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@sagikazarmark
Copy link
Contributor

Summary

Currently the argocd CLI tool creates its config file in the home directory.
Use $XDG_CONFIG_HOME instead.

Motivation

Keep the home directory free from clutter.

Proposal

Support the XDG base directory standard.

Alternatively, introduce an environment variable (eg. ARGOCD_CONFIG_HOME) to allow users controlling the config file location without having to pass --config to every command. This would also be backward compatible.
@sagikazarmark sagikazarmark added the enhancement New feature or request label Nov 6, 2021
@jessesuen
Copy link
Member

Agree. Standards are good

@jessesuen jessesuen added the good first issue Good for newcomers label Nov 9, 2021
@sagikazarmark sagikazarmark mentioned this issue Nov 27, 2021
Merged
10 tasks
@sagikazarmark
Copy link
Contributor Author

@jessesuen Please see the linked PR.

jannfis pushed a commit that referenced this issue Jan 12, 2022
@sagikazarmark
feat: Support XDG Base directory standard (#7638) (#7791)
57e0ffc 
* feat: support XDG Base directory standard

Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>

* chore: set XDG_CONFIG_HOME env var for docs generation

Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>

* chore: regenerate cli docs

Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Support XDG Base directory standard (#7638)
2 participants
@sagikazarmark @jessesuen