feat: Support XDG Base directory standard (#7638)

[sagikazarmark]

Closes #7638

Changes were tested manually (there were no tests covering this feature before, I can provide tests if necessary).

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).

[codecov]

Codecov Report

Merging #7791 (d98c716) into master (722fe92) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #7791      +/-   ##
==========================================
- Coverage   41.53%   41.51%   -0.03%     
==========================================
  Files         174      174              
  Lines       22703    22715      +12     
==========================================
  Hits         9430     9430              
- Misses      11932    11944      +12     
  Partials     1341     1341              

Impacted Files	Coverage Δ
util/localconfig/localconfig.go	2.75% <0.00%> (-0.35%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 722fe92...d98c716. Read the comment docs.

[sagikazarmark]

Hm, the test failure is interesting. I can imagine two solutions:

• Adjust the generated docs
• Add a ARGOCD_CONFIG_DIR env var to retain the current content

The latter probably makes more sense. WDYT?

[sagikazarmark]

Let me know which solution you prefer

/cc @jessesuen

[sagikazarmark]

Ping

I'd love to finish this PR, but I need a decision on the above.

[jannfis]

Thanks for this PR @sagikazarmark.

The CLI docs are autogenerated by https://github.com/argoproj/argo-cd/blob/master/tools/cmd-docs/main.go
For consistency in generated output, it sets HOME to /home/user here:

argo-cd/tools/cmd-docs/main.go

Line 18 in e50d03e

os.Setenv("HOME", "/home/user")

I guess with this change, we need to also set XDG_CONFIG_HOME to /home/user/.config. And then you need to run make codegen (or simply, make clidocsgen) and commit these changes to your PR's branch.

[sagikazarmark]

Thanks for the help @jannfis !

I made the necessary changes.

[sagikazarmark]

Build is still breaking. :\

The lint break seems unrelated (some URL in the helm docs yields 404). The other one seems related, but I can't really say what the problem is.

[jannfis]

LGTM! Thanks @sagikazarmark !