Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume static-files present and volumemount not referenced #8714

Closed
nunojusto opened this issue Mar 8, 2022 · 0 comments · Fixed by #9013
Closed

Volume static-files present and volumemount not referenced #8714

nunojusto opened this issue Mar 8, 2022 · 0 comments · Fixed by #9013
Labels
bug Something isn't working

Comments

@nunojusto
Copy link

Checklist:

  • [ x] I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • [ x] I've included steps to reproduce the bug.

Describe the bug
I was backing up an ArgoCD instance with Velero and got an error with one volume defined in the argocd-server deployment, that does not have a mounted volume in any container.
That does not produce an error in kubernetes, but because velero/restic wants to backup that mount and it's not there, it gives an error.

So, I would say, if we have an old volume (from older manifests) that we don't use anymore, we should remove it.
I know it's an empty dir, but it's still not a best practice to keep it defined and not mounted.

You can see this here

Expected behavior

Not having a volume defined and not mounted

Version

All install manifests

@nunojusto nunojusto added the bug Something isn't working label Mar 8, 2022
crenshaw-dev pushed a commit that referenced this issue Apr 20, 2022
…manifest - Fixes #8714 (#9013)

* fix: Remove orphan static-files volume from ArgoCD server deployment manifest

Signed-off-by: Domonkos Cinke <seayou@gmail.com>

* fix: Make codegen

Signed-off-by: Domonkos Cinke <seayou@gmail.com>

Co-authored-by: Domonkos Cinke <domonkos.cinke@namecheap.com>
wojtekidd pushed a commit to wojtekidd/argo-cd that referenced this issue Apr 25, 2022
…manifest - Fixes argoproj#8714 (argoproj#9013)

* fix: Remove orphan static-files volume from ArgoCD server deployment manifest

Signed-off-by: Domonkos Cinke <seayou@gmail.com>

* fix: Make codegen

Signed-off-by: Domonkos Cinke <seayou@gmail.com>

Co-authored-by: Domonkos Cinke <domonkos.cinke@namecheap.com>
Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant