fix: Remove orphan static-files volume from ArgoCD server deployment manifest - Fixes #8714

[Sea-you]

Signed-off-by: Domonkos Cinke seayou@gmail.com

Fixes #8714

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).

[codecov]

Codecov Report

Merging #9013 (e2995ba) into master (5921e2a) will increase coverage by 0.37%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #9013      +/-   ##
==========================================
+ Coverage   45.07%   45.45%   +0.37%     
==========================================
  Files         212      219       +7     
  Lines       25281    25870     +589     
==========================================
+ Hits        11396    11759     +363     
- Misses      12278    12476     +198     
- Partials     1607     1635      +28     

Impacted Files	Coverage Δ
applicationset/services/scm_provider/github.go	63.52% <0.00%> (-17.65%)	⬇️
cmd/argocd/commands/admin/project_allowlist.go	30.95% <0.00%> (-16.35%)	⬇️
applicationset/generators/pull_request.go	42.85% <0.00%> (-13.40%)	⬇️
applicationset/generators/scm_provider.go	40.25% <0.00%> (-13.19%)	⬇️
server/server.go	54.07% <0.00%> (-1.51%)	⬇️
server/application/application.go	30.50% <0.00%> (-0.87%)	⬇️
util/helm/cmd.go	28.82% <0.00%> (-0.83%)	⬇️
reposerver/repository/repository.go	59.70% <0.00%> (-0.39%)	⬇️
cmd/argocd/commands/root.go	2.00% <0.00%> (-0.09%)	⬇️
cmd/argocd/commands/login.go	2.29% <0.00%> (-0.02%)	⬇️
... and 24 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5921e2a...e2995ba. Read the comment docs.

[crenshaw-dev]

@Sea-you thanks! Can you run make codegen? I think the commit message will also need to have fix: added to the beginning.

[Sea-you]

@crenshaw-dev ptal :)

[crenshaw-dev]

lgtm, thanks!