New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: yaml code blocks under Slack notification service doesn't render properly #8776
Comments
…#8777) * docs: fixes the YAML codefence for `Slack` notification service Signed-off-by: Ole-Martin Bratteng <1681525+omBratteng@users.noreply.github.com> * chore: update `notifications-engine` to get latest docs Signed-off-by: Ole-Martin Bratteng <1681525+omBratteng@users.noreply.github.com> * chore: run `go mod tidy` Signed-off-by: Ole-Martin Bratteng <1681525+omBratteng@users.noreply.github.com>
…roj#8776 (argoproj#8777) * docs: fixes the YAML codefence for `Slack` notification service Signed-off-by: Ole-Martin Bratteng <1681525+omBratteng@users.noreply.github.com> * chore: update `notifications-engine` to get latest docs Signed-off-by: Ole-Martin Bratteng <1681525+omBratteng@users.noreply.github.com> * chore: run `go mod tidy` Signed-off-by: Ole-Martin Bratteng <1681525+omBratteng@users.noreply.github.com> Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>
Was trying to fix the highlights in #10280 then I noticed such issue here. Any helps needed? I can file a new PR to pick up the fix if you'd like :D |
There is a PR open to fix the latest broken section argoproj/notifications-engine#97 |
I see that now. Sure, go ahead. I can cherry-pick the fix into the PR branch. |
I have fixed the indentation, and put you as the author @GalvinGao, so you can get the credit for it. |
Once it gets merged, I'll open a PR here to get the correct version of the go module |
… (#10311) * chore: update `notifications-engine` to get latest docs Signed-off-by: Ole-Martin Bratteng <1681525+omBratteng@users.noreply.github.com> * chore: generate notifications docs Signed-off-by: Ole-Martin Bratteng <1681525+omBratteng@users.noreply.github.com> * chore: run `go mod tidy` Signed-off-by: Ole-Martin Bratteng <1681525+omBratteng@users.noreply.github.com> Signed-off-by: Ole-Martin Bratteng <1681525+omBratteng@users.noreply.github.com>
I think we can close this now as #10311 is merged :D |
Unsure if it is actually out. I see @crenshaw-dev added, and then removed, the cherry-pick label. |
Never mind, just checked now. It's out on the stable version of the docs. |
Let close it @omBratteng ? |
Should be closed now. |
Checklist:
argocd version
.Describe the bug
The YAML examples are rendered as inline code, rather than a code block
To Reproduce
See step 8-10 at https://argo-cd.readthedocs.io/en/stable/operator-manual/notifications/services/slack/
Expected behavior
The YAML examples are rendered as code blocks
Screenshots
Version
Both in stable and latest version of docs.
Logs
N/A only docs
The text was updated successfully, but these errors were encountered: