docs: fixes the YAML codefence for Slack notification service #8776
#8777
Conversation
| apiVersion: v1 | ||
| kind: Secret | ||
| metadata: | ||
| name: <secret-name> | ||
| stringData: | ||
| slack-token: <Oauth-access-token> |
There was a problem hiding this comment.
These have to be in the indented format, as using ```yaml removes the numbering of the ordered list.
Codecov Report
@@ Coverage Diff @@
## master #8777 +/- ##
=======================================
Coverage 42.85% 42.85%
=======================================
Files 186 186
Lines 23359 23359
=======================================
Hits 10011 10011
Misses 11914 11914
Partials 1434 1434 Continue to review full report at Codecov.
|
|
Noticed that the docs are copied from https://github.com/argoproj/notifications-engine, so I've created a PR there to update the YAML. |
|
@omBratteng could you please fix pr checks? |
|
@pasha-codefresh the PR checks that are failing, are because the step gets the markdown files from https://github.com/argoproj/notifications-engine, hence why I opened a PR argoproj/notifications-engine#80 in that repo, which is needed before the failing check can be addressed. |
Signed-off-by: Ole-Martin Bratteng <1681525+omBratteng@users.noreply.github.com>
Signed-off-by: Ole-Martin Bratteng <1681525+omBratteng@users.noreply.github.com>
Signed-off-by: Ole-Martin Bratteng <1681525+omBratteng@users.noreply.github.com>
|
I would've liked if the |
|
Thank you |
…roj#8776 (argoproj#8777) * docs: fixes the YAML codefence for `Slack` notification service Signed-off-by: Ole-Martin Bratteng <1681525+omBratteng@users.noreply.github.com> * chore: update `notifications-engine` to get latest docs Signed-off-by: Ole-Martin Bratteng <1681525+omBratteng@users.noreply.github.com> * chore: run `go mod tidy` Signed-off-by: Ole-Martin Bratteng <1681525+omBratteng@users.noreply.github.com> Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>
Signed-off-by: Ole-Martin Bratteng 1681525+omBratteng@users.noreply.github.com
Fixes [#8776]
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist: