Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow metadata.creationTimestamp to affect sync status #1021

Merged
merged 1 commit into from
Jan 16, 2019

Conversation

jessesuen
Copy link
Member

Resolves #1009

@jessesuen jessesuen requested a review from alexmt January 16, 2019 02:34
@codecov-io
Copy link

codecov-io commented Jan 16, 2019

Codecov Report

Merging #1021 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1021      +/-   ##
==========================================
+ Coverage   36.42%   36.54%   +0.11%     
==========================================
  Files          51       51              
  Lines        7363     7364       +1     
==========================================
+ Hits         2682     2691       +9     
+ Misses       4278     4272       -6     
+ Partials      403      401       -2
Impacted Files Coverage Δ
util/diff/diff.go 66.66% <100%> (+2.7%) ⬆️
server/server.go 46.43% <0%> (+0.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f06be7...335dcfa. Read the comment docs.

@jessesuen jessesuen merged commit 2939907 into argoproj:master Jan 16, 2019
@jessesuen jessesuen deleted the 1009-null-creationTimestamp branch January 16, 2019 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants