Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate JWT tokens field in AppProject spec #11736

Closed

Conversation

crenshaw-dev
Copy link
Member

@crenshaw-dev crenshaw-dev commented Dec 16, 2022

No change in behavior, just clarifying the code/docs.

Background: #2718 (comment)

Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Base: 47.00% // Head: 47.00% // No change to project coverage 👍

Coverage data is based on head (0fea86a) compared to base (a89e489).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11736   +/-   ##
=======================================
  Coverage   47.00%   47.00%           
=======================================
  Files         243      243           
  Lines       40457    40457           
=======================================
  Hits        19017    19017           
  Misses      19525    19525           
  Partials     1915     1915           
Impacted Files Coverage Δ
pkg/apis/application/v1alpha1/app_project_types.go 63.71% <ø> (ø)
pkg/apis/application/v1alpha1/types.go 58.22% <ø> (ø)
util/settings/settings.go 48.42% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@crenshaw-dev
Copy link
Member Author

I need to study this more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant