Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change kustomize version for windows & darwin arm64 environments #15940

Conversation

josephperez3
Copy link
Contributor

Because of kubernetes-sigs/kustomize#5220, Kustomize is blocked on releasing versions past 5.0.3 for windows & darwin arm64. (You can also see them mention it in the release notes) So if you're using darwin or windows arm, 5.1.0 (the default when I used the Makefile) doesn't work.

In the code, I chose 5.0.1 instead of 5.0.3 because there's already a checksum for it.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Signed-off-by: Joseph Perez <perezj0230@gmail.com>
Signed-off-by: Joseph Perez <perezj0230@gmail.com>
@josephperez3 josephperez3 requested a review from a team as a code owner October 13, 2023 02:29
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f8f9ae9) 49.69% compared to head (fe250c8) 49.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #15940      +/-   ##
==========================================
- Coverage   49.69%   49.68%   -0.01%     
==========================================
  Files         267      267              
  Lines       46362    46362              
==========================================
- Hits        23039    23036       -3     
- Misses      21063    21065       +2     
- Partials     2260     2261       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blakepettersson
Copy link
Member

It seems like Kustomize released 5.2.1 on Oct 19th and it looks like it has ARM64 artifacts for Darwin and Windows.

@josephperez3
Copy link
Contributor Author

It seems like Kustomize released 5.2.1 on Oct 19th and it looks like it has ARM64 artifacts for Darwin and Windows.

Ah nice, looks like we got 5.2.1 in the repo now too. Guess I'll close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants