Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump kustomize to v5.2.1 #16054

Merged
merged 2 commits into from Oct 23, 2023
Merged

Conversation

MPV
Copy link
Contributor

@MPV MPV commented Oct 20, 2023

This PR upgrades kustomize from 5.1.1 to 5.2.1:

The main benefit I see is the new support for OCI based helm repos:


Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Also note this upstream issue preventing me from using hack/installers/checksums/add-kustomize-checksums.sh:

Thus I:

  1. cd hack/installers/checksums
  2. commented out this line:
    wget "https://github.com/kubernetes-sigs/kustomize/releases/download/kustomize%2Fv$1/checksums.txt"
  3. downloaded them manually:
$ wget https://github.com/kubernetes-sigs/kustomize/releases/download/kustomize%2Fv5.2.1/kustomize_v5.2.1_darwin_amd64.tar.gz
$ wget https://github.com/kubernetes-sigs/kustomize/releases/download/kustomize%2Fv5.2.1/kustomize_v5.2.1_darwin_arm64.tar.gz
$ wget https://github.com/kubernetes-sigs/kustomize/releases/download/kustomize%2Fv5.2.1/kustomize_v5.2.1_linux_amd64.tar.gz
$ wget https://github.com/kubernetes-sigs/kustomize/releases/download/kustomize%2Fv5.2.1/kustomize_v5.2.1_linux_arm64.tar.gz
$ wget https://github.com/kubernetes-sigs/kustomize/releases/download/kustomize%2Fv5.2.1/kustomize_v5.2.1_linux_ppc64le.tar.gz
$ wget https://github.com/kubernetes-sigs/kustomize/releases/download/kustomize%2Fv5.2.1/kustomize_v5.2.1_linux_s390x.tar.gz
  1. calculated checksums manually:
$ sha256sum kustomize_v5.2.1* > checksums.txt
  1. ran ./add-kustomize-checksums.sh 5.2.1
  2. this PR

Signed-off-by: Victor Sollerhed <victor.sollerhed@pagero.com>
Signed-off-by: Victor Sollerhed <victor.sollerhed@pagero.com>
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (973565e) 49.55% compared to head (f31a6f3) 49.55%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #16054   +/-   ##
=======================================
  Coverage   49.55%   49.55%           
=======================================
  Files         269      269           
  Lines       46595    46595           
=======================================
  Hits        23091    23091           
  Misses      21232    21232           
  Partials     2272     2272           

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MPV MPV marked this pull request as ready for review October 20, 2023 14:53
@MPV MPV requested a review from a team as a code owner October 20, 2023 14:53
@MPV
Copy link
Contributor Author

MPV commented Oct 20, 2023

Any chance for including (cherry-picking/backporting) this into version 2.9?

As it fixes this bug:

Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, let's get this into 2.9. Thanks, @MPV!

@crenshaw-dev crenshaw-dev merged commit 35a9e0c into argoproj:master Oct 23, 2023
28 checks passed
@crenshaw-dev
Copy link
Collaborator

/cherry-pick release-2.9

@gcp-cherry-pick-bot
Copy link

Cherry-pick failed with Merge error 35a9e0cc6dfbd52ba4f97472bd57c3f18efa3c7d into temp-cherry-pick-6a0965-release-2.9

@crenshaw-dev
Copy link
Collaborator

@MPV would you mind opening a PR directly against release-2.9 to cherry-pick?

@MPV
Copy link
Contributor Author

MPV commented Oct 23, 2023

@MPV MPV deleted the kustomize-5.2.1 branch October 23, 2023 18:45
ymktmk pushed a commit to ymktmk/argo-cd that referenced this pull request Oct 29, 2023
* kustomize v5.2.1 checksums

Signed-off-by: Victor Sollerhed <victor.sollerhed@pagero.com>

* kustomize v5.2.1 tool-versions

Signed-off-by: Victor Sollerhed <victor.sollerhed@pagero.com>

---------

Signed-off-by: Victor Sollerhed <victor.sollerhed@pagero.com>
jmilic1 pushed a commit to jmilic1/argo-cd that referenced this pull request Nov 13, 2023
* kustomize v5.2.1 checksums

Signed-off-by: Victor Sollerhed <victor.sollerhed@pagero.com>

* kustomize v5.2.1 tool-versions

Signed-off-by: Victor Sollerhed <victor.sollerhed@pagero.com>

---------

Signed-off-by: Victor Sollerhed <victor.sollerhed@pagero.com>
Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
vladfr pushed a commit to vladfr/argo-cd that referenced this pull request Dec 13, 2023
* kustomize v5.2.1 checksums

Signed-off-by: Victor Sollerhed <victor.sollerhed@pagero.com>

* kustomize v5.2.1 tool-versions

Signed-off-by: Victor Sollerhed <victor.sollerhed@pagero.com>

---------

Signed-off-by: Victor Sollerhed <victor.sollerhed@pagero.com>
tesla59 pushed a commit to tesla59/argo-cd that referenced this pull request Dec 16, 2023
* kustomize v5.2.1 checksums

Signed-off-by: Victor Sollerhed <victor.sollerhed@pagero.com>

* kustomize v5.2.1 tool-versions

Signed-off-by: Victor Sollerhed <victor.sollerhed@pagero.com>

---------

Signed-off-by: Victor Sollerhed <victor.sollerhed@pagero.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants