-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: automate mock generation v2 #18371
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Will Roden <will@roden.cc>
Signed-off-by: Will Roden <will@roden.cc>
Signed-off-by: Will Roden <will@roden.cc>
Signed-off-by: Will Roden <will@roden.cc>
Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com>
10 tasks
blakepettersson
changed the title
chore: automate mock generation, v2
chore: automate mock generation v2
May 22, 2024
blakepettersson
changed the title
chore: automate mock generation v2
chore: automate mock generation v2
May 23, 2024
pasha-codefresh
approved these changes
May 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
rumstead
pushed a commit
to rumstead/argo-cd
that referenced
this pull request
Jun 6, 2024
* Add go:generate statements for mockery Signed-off-by: Will Roden <will@roden.cc> * revert whitespace change Signed-off-by: Will Roden <will@roden.cc> * go generate everything Signed-off-by: Will Roden <will@roden.cc> * make gogen Signed-off-by: Will Roden <will@roden.cc> * chore: upgrade to mockery v2.40.2 Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Will Roden <will@roden.cc> Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Co-authored-by: Will Roden <will@roden.cc> Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
mkieweg
pushed a commit
to mkieweg/argo-cd
that referenced
this pull request
Jun 11, 2024
* Add go:generate statements for mockery Signed-off-by: Will Roden <will@roden.cc> * revert whitespace change Signed-off-by: Will Roden <will@roden.cc> * go generate everything Signed-off-by: Will Roden <will@roden.cc> * make gogen Signed-off-by: Will Roden <will@roden.cc> * chore: upgrade to mockery v2.40.2 Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Will Roden <will@roden.cc> Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Co-authored-by: Will Roden <will@roden.cc>
Hariharasuthan99
pushed a commit
to AmadeusITGroup/argo-cd
that referenced
this pull request
Jun 16, 2024
* Add go:generate statements for mockery Signed-off-by: Will Roden <will@roden.cc> * revert whitespace change Signed-off-by: Will Roden <will@roden.cc> * go generate everything Signed-off-by: Will Roden <will@roden.cc> * make gogen Signed-off-by: Will Roden <will@roden.cc> * chore: upgrade to mockery v2.40.2 Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> --------- Signed-off-by: Will Roden <will@roden.cc> Signed-off-by: Blake Pettersson <blake.pettersson@gmail.com> Co-authored-by: Will Roden <will@roden.cc>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #11391, but with an upgraded version of Mockery which works with Go 1.22.
Closes #11390
Checklist: