Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate mocks with make gogen #11390

Closed
WillAbides opened this issue Nov 21, 2022 · 0 comments · Fixed by #18371
Closed

Generate mocks with make gogen #11390

WillAbides opened this issue Nov 21, 2022 · 0 comments · Fixed by #18371
Labels
enhancement New feature or request

Comments

@WillAbides
Copy link
Contributor

I'm not sure this should be an enhancement, but it seems like the best fit of the issue templates.

Summary

Generate mocks with make gogen.

Motivation

I was doing some recreational coding to explore argo-cd and made a change to a mocked interface. This caused build errors that I expected make gogen to fix. I did some searching and eventually found a PR comment by @alexmt with instructions. The comment also says "We definitely should automate mocks generation", so I decided to have a go at that.

Proposal

Add //go:generate comments that generate mocks. I've coded this up and will make a companion PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant