-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add noProxy field to repository & repository templates #18526
feat: add noProxy field to repository & repository templates #18526
Conversation
7c5c4b1
to
e7a3a5f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #18526 +/- ##
==========================================
+ Coverage 55.86% 55.87% +0.01%
==========================================
Files 316 316
Lines 43741 43763 +22
==========================================
+ Hits 24434 24452 +18
- Misses 16745 16754 +9
+ Partials 2562 2557 -5 ☔ View full report in Codecov by Sentry. |
8b84fa7
to
a8875fd
Compare
0c4bf79
to
7bb889b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@the-technat gave me a demo in Swiss Posts environment. Worked like a charm 😎
2de3343
to
1663ff8
Compare
7da6d74
to
ea0eee6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
572383f
to
f0b899e
Compare
@the-technat there are some conflicts which needs to be resolved. |
Head branch was pushed to by a user without write access
f0b899e
to
6e768fd
Compare
Signed-off-by: Nathanael Liechti <technat@technat.ch>
6e768fd
to
68c1a79
Compare
❤️ 🙏 |
Adds support for noProxy on repository & repository templates
Closes #18323
Thanks to @chetan-rns for adding the initial first-class proxy support! Adding noProxy to this existing feature was thus made rather easy.
I can confirm that the feature works as intended. It was tested locally and inside Swiss Post's EKS environment (dev stage). If someone wants to test as well, I built the image with the PR-commit state.
Checklist: