feat: add noProxy field to repository & repository templates #18526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-technat
force-pushed
the
feat/repo-creds-no_proxy
branch
3 times, most recently
from
7c5c4b1
to
e7a3a5f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #18526 +/- ##
==========================================
+ Coverage 55.86% 55.87% +0.01%
==========================================
Files 316 316
Lines 43741 43763 +22
==========================================
+ Hits 24434 24452 +18
- Misses 16745 16754 +9
+ Partials 2562 2557 -5 ☔ View full report in Codecov by Sentry. |
the-technat
force-pushed
the
feat/repo-creds-no_proxy
branch
2 times, most recently
from
8b84fa7
to
a8875fd
Compare
LinoSteffen
approved these changes
Jun 13, 2024
the-technat
force-pushed
the
feat/repo-creds-no_proxy
branch
4 times, most recently
from
0c4bf79
to
7bb889b
Compare
mkilchhofer
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
@the-technat gave me a demo in Swiss Posts environment. Worked like a charm 😎
14 tasks
the-technat
force-pushed
the
feat/repo-creds-no_proxy
branch
8 times, most recently
from
2de3343
to
1663ff8
Compare
crenshaw-dev
previously requested changes
Jun 21, 2024
the-technat
force-pushed
the
feat/repo-creds-no_proxy
branch
4 times, most recently
from
7da6d74
to
ea0eee6
Compare
agaudreault
approved these changes
Jul 22, 2024
the-technat
force-pushed
the
feat/repo-creds-no_proxy
branch
2 times, most recently
from
572383f
to
f0b899e
Compare
crenshaw-dev
approved these changes
Aug 20, 2024
|
@the-technat there are some conflicts which needs to be resolved. |
auto-merge was automatically disabled
August 20, 2024 15:08
Head branch was pushed to by a user without write access
the-technat
force-pushed
the
feat/repo-creds-no_proxy
branch
from
f0b899e
to
6e768fd
Compare
Signed-off-by: Nathanael Liechti <technat@technat.ch>
the-technat
force-pushed
the
feat/repo-creds-no_proxy
branch
from
6e768fd
to
68c1a79
Compare
|
❤️ 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for noProxy on repository & repository templates
Closes #18323
Thanks to @chetan-rns for adding the initial first-class proxy support! Adding noProxy to this existing feature was thus made rather easy.
I can confirm that the feature works as intended. It was tested locally and inside Swiss Post's EKS environment (dev stage). If someone wants to test as well, I built the image with the PR-commit state.
Checklist: