Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #2060 - Enpoint incorrectly considered top level managed resource #2129

Merged
merged 1 commit into from
Aug 9, 2019
Merged

Issue #2060 - Enpoint incorrectly considered top level managed resource #2129

merged 1 commit into from
Aug 9, 2019

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented Aug 9, 2019

Closes #2060

@alexmt alexmt requested review from alexec and jessesuen August 9, 2019 01:09
@alexmt alexmt force-pushed the 2060-endpoint-service-parent branch from a250207 to 46ca856 Compare August 9, 2019 01:11
@codecov
Copy link

codecov bot commented Aug 9, 2019

Codecov Report

Merging #2129 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2129      +/-   ##
==========================================
+ Coverage    34.3%   34.34%   +0.03%     
==========================================
  Files          92       92              
  Lines       14609    14432     -177     
==========================================
- Hits         5011     4956      -55     
+ Misses       8938     8821     -117     
+ Partials      660      655       -5
Impacted Files Coverage Δ
controller/cache/cluster.go 63.44% <100%> (+0.77%) ⬆️
controller/cache/node.go 94.66% <100%> (+5.62%) ⬆️
util/settings/settings.go 21.8% <0%> (-5.21%) ⬇️
controller/appcontroller.go 41.7% <0%> (+1.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b17f330...46ca856. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 9, 2019 •
edited
Loading

Codecov Report

Merging #2129 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2129      +/-   ##
==========================================
+ Coverage    34.3%   34.34%   +0.03%     
==========================================
  Files          92       92              
  Lines       14609    14432     -177     
==========================================
- Hits         5011     4956      -55     
+ Misses       8938     8821     -117     
+ Partials      660      655       -5
Impacted Files Coverage Δ
controller/cache/cluster.go 63.44% <100%> (+0.77%) ⬆️
controller/cache/node.go 94.66% <100%> (+5.62%) ⬆️
util/settings/settings.go 21.8% <0%> (-5.21%) ⬇️
controller/appcontroller.go 41.7% <0%> (+1.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b17f330...46ca856. Read the comment docs.

@alexec alexec added this to the v1.2 milestone Aug 9, 2019
@alexmt alexmt merged commit 9a59e9a into argoproj:master Aug 9, 2019
alexmt pushed a commit that referenced this pull request Aug 9, 2019
Issue #2060 - Enpoint incorrectly considered top level managed resour…
3f31224 
…ce (#2129)
@alexmt alexmt deleted the 2060-endpoint-service-parent branch August 9, 2019 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

@jessesuen jessesuen Awaiting requested review from jessesuen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

Endpoint is no longer shown as a child of services
2 participants
@alexmt @alexec