Fix flaky TestOrphanedResource test #2210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexec
approved these changes
Aug 23, 2019
|
still failing mind you |
alexmt
force-pushed
the
orphaned-resources-flaky
branch
from
ea1a79b
to
da429cc
Compare
Codecov Report
@@ Coverage Diff @@
## master #2210 +/- ##
======================================
Coverage 37.7% 37.7%
======================================
Files 97 97
Lines 13629 13629
======================================
Hits 5139 5139
Misses 7819 7819
Partials 671 671Continue to review full report at Codecov.
|
|
Ops, condition implementation had be typo. Going to rerun CI multiple times to make sure test is stable, before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.