Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JS error on application creation page if no plugins configured #2432

Merged
merged 1 commit into from
Oct 7, 2019

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented Oct 7, 2019

No description provided.

@alexmt alexmt requested a review from alexec October 7, 2019 18:01
@alexec alexec merged commit 5bea7c3 into argoproj:master Oct 7, 2019
@codecov
Copy link

codecov bot commented Oct 7, 2019

Codecov Report

Merging #2432 into master will decrease coverage by 1.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2432      +/-   ##
==========================================
- Coverage   39.45%   38.23%   -1.22%     
==========================================
  Files         104      104              
  Lines       15119    14652     -467     
==========================================
- Hits         5965     5602     -363     
+ Misses       8389     8297      -92     
+ Partials      765      753      -12
Impacted Files Coverage Δ
controller/appcontroller.go 44.15% <0%> (-6.47%) ⬇️
pkg/apis/application/v1alpha1/types.go 58.57% <0%> (-3.73%) ⬇️
controller/state.go 71.56% <0%> (-2.44%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc6be7f...ece776b. Read the comment docs.

@alexmt alexmt deleted the app-creation-error branch September 4, 2020 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants