feat: Supports the validate-false option at an app level. Closes #1063

[alexec]

Checklist:

• I've created an enhancement proposal and I feel I've gotten a green light from the community.
• My build is green (troubleshooting builds).
• Optional. My organisation is added to the README.

Closes #1063

Reviewer checklist:

• Happy with the schema changes?
• Happy with using ! to remove flag? Similar to how other tools do this.
• @alexmt can you please look at the changes around syncPolicy.automated in the UI?

[codecov]

Codecov Report

Merging #2542 into master will decrease coverage by 0.88%.
The diff coverage is 35.2%.

@@            Coverage Diff             @@
##           master    #2542      +/-   ##
==========================================
- Coverage   39.53%   38.65%   -0.89%     
==========================================
  Files          40      168     +128     
  Lines        1171    18248   +17077     
  Branches      203      237      +34     
==========================================
+ Hits          463     7053    +6590     
- Misses        706    10321    +9615     
- Partials        2      874     +872

Impacted Files	Coverage Δ
ui/src/app/shared/components/page.tsx	39.28% <ø> (+1.78%)	⬆️
.../src/app/applications/components/resource-label.ts	100% <ø> (ø)
server/account/account.go	43.75% <ø> (ø)
.../app/shared/components/progress/progress-popup.tsx	90.9% <ø> (ø)
util/argo/audit_logger.go	0% <ø> (ø)
...hared/components/editable-panel/editable-panel.tsx	22% <ø> (-0.45%)	⬇️
util/clusterauth/clusterauth.go	21.64% <ø> (ø)
ui/src/app/applications/components/resources.ts	100% <ø> (ø)
reposerver/repository/repository.go	59.89% <ø> (ø)
.../app/shared/components/yaml-editor/yaml-editor.tsx	32.25% <ø> (ø)	⬆️
... and 181 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84f3b81...2021227. Read the comment docs.

[alexec]

@yann-soubeyrand can you take a look at this solution please?

[yann-soubeyrand]

Thanks a lot @alexec! I'm wondering if renaming the option noValidate to validate and defaulting it to true wouldn't clarify things (it would directly map to kubectl CLI option --validate=false)? Apart from that, this looks good to me and will totally address my needs ;-)

[alexec]

Thank you @yann-soubeyrand . @alexmt thoughts?

[alexec]

@yann-soubeyrand, @alexmt agrees.

changes implemented

[alexec]

Changes since last review:

• Change schema to add syncPolicy.SyncOptions []string, as discussed with @jessesuen .
• Adds support to CLI to add an app with sync-options.
• Adds support to UI to add and app, or update an app's sync options.

[alexec]

CLI examples:

argocd app create guestbook --repo https://github.com/argoproj/argocd-example-apps.git --path guestbook --dest-namespace default --dest-server https://kubernetes.default.svc --directory-recurse --sync-option Validate=false

Unset flag:

$ argocd app set guestbook --sync-option '!Validate=false'

Set flag:

$ argocd app set guestbook --sync-option 'Validate=false'

[yann-soubeyrand]

Hi, what's the status of this PR? What can we do to help it being merged?

[LeonardAukea]

It seems that we are dependent on this PR to be merged in order to deploy cert-manager with argo without using multiple hacks that fall short. What is the status of this and is there anything we can do to speed up the process?

[alexec]

@jessesuen @alexmt do you want to progress this in v1.5 please? I can find some time to fix the merges, but that would only make sense if you have time to review the PR. Can I please ask if you can review the PR? Thank you.

[alexmt]

@alexec I'm working on merging master changes and preparing to merge this PR

[alexec]

ok - let me know if you need any assist

[alexmt]

@alexec , I've changed the UI for sync options. Instead of free form test implemented checkboxes, so user don't have to learn syntax of supported options:

does it looks good to you?