Issue #2339 - Controller should compare with latest git revision if app has changed #2543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Oct 22, 2019
alexmt
force-pushed
the
2339-use-latest-revision-if-app-changes
branch
from
50c4818
to
28aad8a
Compare
Codecov Report
@@ Coverage Diff @@
## master #2543 +/- ##
==========================================
- Coverage 38.09% 38.03% -0.06%
==========================================
Files 114 114
Lines 15838 15834 -4
==========================================
- Hits 6033 6023 -10
- Misses 9021 9032 +11
+ Partials 784 779 -5
Continue to review full report at Codecov.
|
alexec
requested changes
Oct 22, 2019
| @@ -601,6 +601,22 @@ func TestNeedRefreshAppStatus(t *testing.T) { | |||
| assert.Equal(t, argoappv1.RefreshTypeHard, refreshType) | |||
| assert.Equal(t, CompareWithLatest, compareWith) | |||
| } | |||
|
|
|||
| { | |||
There was a problem hiding this comment.
can you comment what this test is doing please?
| app := app.DeepCopy() | ||
| ctrl.requestAppRefresh(app.Name, ComparisonWithNothing) | ||
| app.Spec.Source.Helm = &argoappv1.ApplicationSourceHelm{ | ||
| Parameters: []argoappv1.HelmParameter{{ |
There was a problem hiding this comment.
do you need this parameters?
There was a problem hiding this comment.
yes. added comment which explains the change
alexmt
force-pushed
the
2339-use-latest-revision-if-app-changes
branch
from
28aad8a
to
b78cfa0
Compare
alexec
approved these changes
Oct 22, 2019
…ion if app has changed
alexmt
force-pushed
the
2339-use-latest-revision-if-app-changes
branch
from
b78cfa0
to
efaaac5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: