Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow you to sync local Helm apps. Fixes #2741 #2747

Merged
merged 2 commits into from
Nov 21, 2019

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Nov 20, 2019

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Optional. My organization is added to the README.
  • I've signed the CLA and my build is green (troubleshooting builds).

Fixes #2741

Needs back-porting to v1.3

@alexec alexec requested a review from simster7 November 20, 2019 17:34
@alexec alexec added this to the v1.3 milestone Nov 20, 2019
Copy link
Member

@simster7 simster7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheeky little bug

@codecov
Copy link

codecov bot commented Nov 20, 2019

Codecov Report

Merging #2747 into master will increase coverage by 0.54%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2747      +/-   ##
==========================================
+ Coverage   37.77%   38.32%   +0.54%     
==========================================
  Files         156      156              
  Lines       17564    17289     -275     
  Branches      203      229      +26     
==========================================
- Hits         6635     6626       -9     
+ Misses      10106     9839     -267     
- Partials      823      824       +1
Impacted Files Coverage Δ
cmd/argocd/commands/app.go 1.02% <0%> (+0.16%) ⬆️
controller/appcontroller.go 44.89% <0%> (-1.23%) ⬇️
ui/src/app/applications/components/utils.tsx 46.68% <0%> (ø) ⬆️
ui/src/app/shared/services/projects-service.ts 19.71% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5980b60...67e5165. Read the comment docs.

@alexec alexec changed the title Allow you to sync local Helm apps. Allow you to sync local Helm apps. Fixes #2741 Nov 20, 2019
Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
@alexec alexec marked this pull request as ready for review November 21, 2019 02:20
@alexec alexec merged commit c2ff8e8 into argoproj:master Nov 21, 2019
@alexec alexec deleted the fix-local branch November 21, 2019 02:20
alexec added a commit that referenced this pull request Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

argocd local sync cannot parse kubernetes version
3 participants