Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trim suffix backslash in cluster server URL #4037

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

imrenagi
Copy link
Contributor

@imrenagi imrenagi commented Aug 3, 2020

solving #3993

Signed-off-by: Imre Nagi imre.nagi@go-jek.com

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Optional. My organization is added to USERS.md.
  • I've signed the CLA and my build is green (troubleshooting builds).

Signed-off-by: Imre Nagi <imre.nagi@go-jek.com>
@imrenagi
Copy link
Contributor Author

imrenagi commented Aug 3, 2020

@jannfis please take a look to this one. thanks!

@codecov-commenter
Copy link

Codecov Report

Merging #4037 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4037   +/-   ##
=======================================
  Coverage   42.36%   42.36%           
=======================================
  Files         123      123           
  Lines       18200    18200           
=======================================
  Hits         7710     7710           
  Misses       9491     9491           
  Partials      999      999           
Impacted Files Coverage Δ
util/db/cluster.go 63.86% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c483449...ae9475b. Read the comment docs.

@alexmt alexmt self-assigned this Aug 3, 2020
Copy link
Collaborator

@alexmt alexmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit 5908963 into argoproj:master Aug 4, 2020
rachelwang20 pushed a commit to rachelwang20/argo-cd that referenced this pull request Aug 5, 2020
Signed-off-by: Imre Nagi <imre.nagi@go-jek.com>
skibum55 pushed a commit to skibum55/argo-cd that referenced this pull request Aug 10, 2020
Signed-off-by: Imre Nagi <imre.nagi@go-jek.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants