Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update redis to 5.0.10 #4767

Merged
merged 3 commits into from
Nov 5, 2020
Merged

Conversation

jannfis
Copy link
Member

@jannfis jannfis commented Nov 5, 2020

Fixes #4748

Update redis from 5.0.8 to latest 5.0.10 patch release for both, argocd-redis and argocd-redis-ha workloads.

Also moves non-HA redis workload to alpine base image.

Superficially tested with both, HA and non-HA installations.

Signed-off-by: jannfis jann@mistrust.net

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I've signed the CLA and my build is green (troubleshooting builds).

Signed-off-by: jannfis <jann@mistrust.net>
Signed-off-by: jannfis <jann@mistrust.net>
Signed-off-by: jannfis <jann@mistrust.net>
@@ -1,4 +1,4 @@
FROM redis:5.0.8 as redis
FROM redis:5.0.10 as redis
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't use alpine image here, since redis binaries are not linked statically (and we copy them later on for local execution within the Docker image)

@jannfis jannfis marked this pull request as ready for review November 5, 2020 20:12
@jannfis jannfis changed the title fix: Update redis to 5.0.10 chore: Update redis to 5.0.10 Nov 5, 2020
@jessesuen jessesuen merged commit 3e19b2f into argoproj:master Nov 5, 2020
@jannfis jannfis added the cherry-pick/1.7 Candidate for cherry picking into the 1.7 release branch label Nov 13, 2020
@jannfis
Copy link
Member Author

jannfis commented Nov 13, 2020

@alexmt Can we cherry pick this one in 1.7 branch as well please?

alexmt pushed a commit that referenced this pull request Nov 17, 2020
Signed-off-by: jannfis <jann@mistrust.net>
@alexmt
Copy link
Collaborator

alexmt commented Nov 17, 2020

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick/1.7 Candidate for cherry picking into the 1.7 release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update redis version
3 participants