Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix incorrect OCI Helm registiries assumptions #5888

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

alexmt
Copy link
Collaborator

@alexmt alexmt commented Mar 26, 2021

Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com

Fixes #5883
Fixes #5558
Fixes #5257

PR fixes incorrect handling of OCI Helm registries:

@alexmt alexmt force-pushed the 5628-fix-invalid-oci-assumption branch from 96d324a to 751b31c Compare March 26, 2021 21:20
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
@codecov
Copy link

codecov bot commented Mar 26, 2021

Codecov Report

Merging #5888 (61650d2) into master (1c318f3) will increase coverage by 0.02%.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5888      +/-   ##
==========================================
+ Coverage   40.88%   40.91%   +0.02%     
==========================================
  Files         147      147              
  Lines       19619    19620       +1     
==========================================
+ Hits         8021     8027       +6     
+ Misses      10493    10489       -4     
+ Partials     1105     1104       -1     
Impacted Files Coverage Δ
pkg/apis/application/v1alpha1/types.go 57.44% <0.00%> (ø)
util/helm/client.go 45.02% <50.00%> (+0.38%) ⬆️
reposerver/repository/repository.go 62.80% <80.00%> (+0.34%) ⬆️
util/argo/argo.go 60.75% <100.00%> (+0.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c318f3...61650d2. Read the comment docs.

Copy link
Contributor

@kshamajain99 kshamajain99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit 719d6a9 into argoproj:master Mar 26, 2021
@alexmt alexmt deleted the 5628-fix-invalid-oci-assumption branch March 26, 2021 22:33
alexmt pushed a commit that referenced this pull request Mar 29, 2021
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
shubhamagarwal19 pushed a commit to shubhamagarwal19/argo-cd that referenced this pull request Apr 15, 2021
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
@jannfis jannfis added the needs-verification PR requires pre-release verification label Jun 25, 2021
@alexmt alexmt removed the needs-verification PR requires pre-release verification label Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants