Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow argo-cd to build on ppc64le #6441

Closed
wants to merge 10 commits into from
Closed

feat: allow argo-cd to build on ppc64le #6441

wants to merge 10 commits into from

Conversation

dberg1
Copy link

@dberg1 dberg1 commented Jun 9, 2021

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Damien Bergamini and others added 5 commits June 3, 2021 15:29
@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #6441 (eed79ce) into master (07cc533) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6441      +/-   ##
==========================================
- Coverage   41.53%   41.53%   -0.01%     
==========================================
  Files         174      174              
  Lines       22774    22705      -69     
==========================================
- Hits         9459     9430      -29     
+ Misses      11975    11921      -54     
- Partials     1340     1354      +14     
Impacted Files Coverage Δ
controller/sync.go 57.51% <0.00%> (-7.63%) ⬇️
server/application/application.go 31.20% <0.00%> (-1.56%) ⬇️
util/session/sessionmanager.go 68.75% <0.00%> (-1.37%) ⬇️
server/project/project.go 52.50% <0.00%> (-0.19%) ⬇️
util/clusterauth/clusterauth.go 66.66% <0.00%> (-0.16%) ⬇️
util/rbac/rbac.go 76.47% <0.00%> (-0.03%) ⬇️
util/argo/diff/diff.go 52.27% <0.00%> (ø)
util/argo/diff/ignore.go 100.00% <0.00%> (ø)
cmd/argocd/commands/admin/settings.go 68.14% <0.00%> (ø)
util/argo/normalizer.go
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07cc533...eed79ce. Read the comment docs.

Damien Bergamini added 2 commits January 14, 2022 07:48
Signed-off-by: Damien Bergamini <dbergami@us.ibm.com>
Signed-off-by: Damien Bergamini <dbergami@us.ibm.com>
@dberg1
Copy link
Author

dberg1 commented Jan 14, 2022

For kustomize, ppc64le release binaries are only available starting with v4.4.1:
https://github.com/kubernetes-sigs/kustomize/releases/download/kustomize%2Fv4.4.1/kustomize_v4.4.1_linux_ppc64le.tar.gz
Instead of doing a go get in hack/installers/install-kustomize-linux.sh, we could switch to kustomize v4.4.1.

@dberg1
Copy link
Author

dberg1 commented Jan 14, 2022

aws-cli for ppc64le is not available as a downloadable archive from amazon.
It needs to be built from sources. I'll see if I can integrate this into the build process.
With this Dockerfile, I can build the aws-cli archive for ppc64le in a reproducible way:

FROM python:3.8

ARG VERSION=2.4.6

WORKDIR /tmp

RUN pip install cmake && \
    curl -sLf --retry 3 -o $VERSION.zip https://github.com/aws/aws-cli/archive/refs/tags/$VERSION.zip && \
    unzip $VERSION.zip && \
    cd aws-cli-$VERSION/ && \
    # Work-around a bug in PyInstaller 4.2 \
    # See https://github.com/pyinstaller/pyinstaller/issues/2849 \
    # and https://github.com/pyinstaller/pyinstaller/issues/2848 \
    sed -i 's/^PyInstaller==4\.2/PyInstaller==4.8/' requirements-build.txt && \
    python scripts/installers/make-exe

@jannfis
Copy link
Member

jannfis commented Jan 14, 2022

aws-cli for ppc64le is not available as a downloadable archive from amazon

We are in the process of replacing aws-cli with something different, see #8032. So probably we should wait until that is complete and merged.

Just as a heads up, I'm also working on having official ppc64le release assets (containers and binaries) here: #8155 - I will pause my efforts on that until your PR is merged. Sorry, I haven't seen your effort previously.

@skuethe
Copy link

skuethe commented Feb 16, 2022

Hi and thank you for your effort on this topic @dberg1 .
Would it be possible to also add s390x arch support in this PR?

It seems to have the same restrictions over which you stumbled upon already (f.e. kustomize being only available starting with v4.4.1).

Would be much appreciated for enabling argocd on zLinux (f.e. while using Openshift GitOps Operator).

@samding01
Copy link
Contributor

Hi @dberg1 @skuethe

We worked on the port to s390x & ppc64le, here is the code changed and verified on the both platforms.
http://pastebin.test.redhat.com/1036562

As for the esbuild-loader, because the current version does not support s390x, so it has to update to version 2.18.0

@skuethe
Copy link

skuethe commented Mar 24, 2022

We worked on the port to s390x & ppc64le, here is the code changed and verified on the both platforms.
http://pastebin.test.redhat.com/1036562

Thank you for your feedback, but that seems to be an internal Red Hat URL. DNS is not resolvable from outside :)
Maybe @dberg1 can use it (as he seems to be also working at Red Hat).

alexmt pushed a commit that referenced this pull request Apr 22, 2022
* Support build on s390x and ppc64le

Signed-off-by: Sam Ding <samding@ca.ibm.com>
wojtekidd pushed a commit to wojtekidd/argo-cd that referenced this pull request Apr 25, 2022
…oproj#8890)

* Support build on s390x and ppc64le

Signed-off-by: Sam Ding <samding@ca.ibm.com>
Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>
@skuethe
Copy link

skuethe commented Apr 29, 2022

#8890 was successfully merged - this can probably be closed, right?

@alexmt
Copy link
Collaborator

alexmt commented May 3, 2022

Agree. Closing since #8890 is merged.

@alexmt alexmt closed this May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants