chore: Support build on s390x and ppc64le (follow #6441)

[samding01]

This PR is following #6441 for supporting s390x and ppc64le. Verified on amd64/s390x/ppc64le platforms.

• Changed esbuild-loader to version 2.18.0 as well as kustomize to 4.4.1 to support s390x;
• Added g++ in the container to make node-sass working for both ppc64le and s390x;

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).

[codecov]

Codecov Report

Merging #8890 (a91e000) into master (e5e3b0f) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8890      +/-   ##
==========================================
- Coverage   45.53%   45.51%   -0.02%     
==========================================
  Files         219      219              
  Lines       25897    25897              
==========================================
- Hits        11792    11787       -5     
- Misses      12463    12467       +4     
- Partials     1642     1643       +1     

Impacted Files	Coverage Δ
applicationset/services/scm_provider/github.go	75.29% <0.00%> (-5.89%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5e3b0f...a91e000. Read the comment docs.

[alexmt]

Thank you @samding01 ! Please add new platforms in CI so we can see how much longer image build it going to take:

argo-cd/.github/workflows/image.yaml

Line 83 in c59b8ea

IMAGE_PLATFORMS=linux/amd64,linux/arm64

[alexmt]

Codegen changes are not related to PR changes. Please pull latest master into your branch to fix the build failure.

[samding01]

Thank you @samding01 ! Please add new platforms in CI so we can see how much longer image build it going to take:

argo-cd/.github/workflows/image.yaml

Line 83 in c59b8ea

IMAGE_PLATFORMS=linux/amd64,linux/arm64

@alexmt
Is it good to add like follows?

IMAGE_PLATFORMS=linux/amd64,linux/arm64,linux/s390x,linux/ppc64le

[krishvoor]

Hi @jopit ^^
As discussed, can you take a peek plz?

[samding01]

The failure of Image / publish (pull_request) Failing after 16m testing is related to awscli-linux,
amd64 downloads it from https://awscli.amazonaws.com/awscli-exe-linux-x86_64-v2.4.6.zip.
But seems no s390x or ppc64le versions. Here is the github: https://github.com/aws/aws-cli/tree/2.4.6
How to solve this issue?

[levivic]

hi @alexmt, seems the aws-cli, the missing dependency on s390x and ppc64le, is still a blocker for us. Without it, the ci workflow check will always fail while s390x/ppc64le platforms specified. I know there is the push of #8032, besides that, how can we progress this further at this moment?

i am seeing similar requests for Power, blocked for the same reason: at #6441 and #8155
and a z request redhat-developer/gitops-operator#278

[levivic]

Thank you @samding01 ! Please add new platforms in CI so we can see how much longer image build it going to take:

argo-cd/.github/workflows/image.yaml

Line 83 in c59b8ea

IMAGE_PLATFORMS=linux/amd64,linux/arm64

@alexmt Not sure if ppc64le and s390x are supported in CI, if not, maybe we could remove them in image.yaml?

[alexmt]

@samding01 Sorry for blocking PR for so long. The #8032 has been merged and AWS CLI is no longer bundled into image. CI should pass after merging master changes

[samding01]

@alexmt After updating (pull upstream) the source repo, the CI workflow tests show Image / publish (pull_request) is passed, but
Integration tests / Check changes to generated code (pull_request) is still failed, the error msg is limited and does not show the reason of the error, can you let's know what is this and how to change to avoid it? Thx.

[crenshaw-dev]

@samding01 that error can generally be resolved by running make codegen.

[samding01]

@crenshaw-dev Thank you for your information, Integration tests / Check changes to generated code (pull_request) is a CI workflow test, how do I run make codegen? Can you provide more info? Thanks

[34fathombelow]

@samding01 you do this on your local copy of your branch. More info can be found @ https://argo-cd.readthedocs.io/en/stable/developer-guide/ci/#why-does-the-codegen-step-fail Make sure you have followed the toolchain setup guide.

[alexmt]

@samding01, I've checked the CI logs. Looks like only generated manifests are different. This is happened because of kustomize upgrade. You can run make manifests - it requires only docker. make codegen should work too but it will take much more time.

[alexmt]

LGTM! Thank you!

[samding01]

Thanks @alexmt @34fathombelow