fix: applications page is crashing if nothing marked as favorites #8356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pasha-codefresh
commented
Feb 3, 2022
•
pasha-codefresh
commented
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Signed-off-by: pashavictorovich <pavel@codefresh.io>
Codecov Report
@@ Coverage Diff @@
## master #8356 +/- ##
==========================================
- Coverage 41.91% 41.90% -0.01%
==========================================
Files 178 178
Lines 23003 22854 -149
==========================================
- Hits 9641 9578 -63
+ Misses 11979 11900 -79
+ Partials 1383 1376 -7
Continue to review full report at Codecov.
|
Signed-off-by: pashavictorovich <pavel@codefresh.io>
chetan-rns
approved these changes
Feb 3, 2022
|
I think this should be cherry-picked to the 2.3 branch |
alexmt
approved these changes
Feb 3, 2022
alexmt
pushed a commit
that referenced
this pull request
Feb 3, 2022
) fix: applications page is crashing if nothing marked as favorites (#8356) Signed-off-by: pashavictorovich <pavel@codefresh.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.