Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: close sliding panel on escape key, issue #8225 #8465

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

reginapizza
Copy link
Contributor

@reginapizza reginapizza commented Feb 11, 2022

Closes #8225
NOTE: need to merge argoproj/argo-ui#184 first

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #8465 (de5ba45) into master (4265746) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #8465      +/-   ##
==========================================
- Coverage   45.54%   45.49%   -0.05%     
==========================================
  Files         219      219              
  Lines       25893    25893              
==========================================
- Hits        11792    11781      -11     
- Misses      12459    12473      +14     
+ Partials     1642     1639       -3     
Impacted Files Coverage Δ
applicationset/services/scm_provider/github.go 63.52% <0.00%> (-17.65%) ⬇️
applicationset/services/scm_provider/utils.go 87.75% <0.00%> (+4.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4265746...de5ba45. Read the comment docs.

Copy link
Member

@rbreeze rbreeze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once Argo UI PR is merged

@reginapizza reginapizza force-pushed the escapeKeyClosePanel branch 2 times, most recently from 494c0e4 to 11f0665 Compare April 14, 2022 16:17
Signed-off-by: Regina Scott <rescott@redhat.com>
@rbreeze rbreeze merged commit 9ddadb0 into argoproj:master Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Escape key should close sliding window in UI
3 participants