feat: CLI add printout of what has been deleted

[reginapizza]

Closes #8828

CLI will print out the following upon resource deletion:

$ argocd app delete guestbook
Are you sure you want to delete 'guestbook' and all its resources? [y/n]
y
application 'guestbook' deleted

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• Optional. My organization is added to USERS.md.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).

[pasha-codefresh]

Thank you, LGTM

[terrytangyuan]

LGTM

[danielhelfand]

Just wanted to note that this will say things are deleted even if nothing is deleted. There should be some confirmation that the app was actually deleted before the message is displayed.

An example of this is when you try to delete an app that doesn't exist:

dist/argocd app delete foo
Are you sure you want to delete 'foo' and all its resources? [y/n]
y
application 'foo' deleted
FATA[0003] rpc error: code = NotFound desc = applications.argoproj.io "foo" not found 

This would also occur when n is input to say not to delete an app.

[danielhelfand]

Maybe the deletion confirmation message should be output after here assuming the err is nil from the Delete call?

[reginapizza]

@danielhelfand thanks for catching that, let me know if what I have now is better!

[codecov]

Codecov Report

Merging #8894 (3243807) into master (8847a31) will increase coverage by 1.51%.
The diff coverage is 63.30%.

@@            Coverage Diff             @@
##           master    #8894      +/-   ##
==========================================
+ Coverage   43.40%   44.92%   +1.51%     
==========================================
  Files         186      212      +26     
  Lines       23373    25262    +1889     
==========================================
+ Hits        10145    11348    +1203     
- Misses      11779    12310     +531     
- Partials     1449     1604     +155     

Impacted Files	Coverage Δ
applicationset/services/pull_request/fake.go	0.00% <0.00%> (ø)
applicationset/utils/createOrUpdate.go	0.00% <0.00%> (ø)
applicationset/utils/policy.go	0.00% <0.00%> (ø)
cmd/argocd/commands/app.go	9.16% <0.00%> (-0.01%)	⬇️
applicationset/services/pull_request/github.go	14.00% <14.00%> (ø)
...is/applicationset/v1alpha1/applicationset_types.go	34.69% <34.69%> (ø)
applicationset/generators/scm_provider.go	53.44% <53.44%> (ø)
applicationset/generators/pull_request.go	56.25% <56.25%> (ø)
...cationset/controllers/applicationset_controller.go	56.75% <56.75%> (ø)
applicationset/services/repo_service.go	57.14% <57.14%> (ø)
... and 20 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e864652...3243807. Read the comment docs.

[danielhelfand]

@reginapizza lgtm! Thanks for making the change.

You need to rebase around master branch to fix this failed workflow run: Integration tests / Check changes to generated code (pull_request). The failure is unrelated to your change and was fixed in #8912.