Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: generate manifests to include bitbucket properties #8912

Merged
merged 1 commit into from Mar 28, 2022

Conversation

danielhelfand
Copy link
Contributor

Build is failing in #8814 cause it looks like manifests are not up to date. This pr adds missing generated code to fix build.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

Signed-off-by: Daniel Helfand <helfand.4@gmail.com>
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #8912 (600b4eb) into master (5b44356) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #8912   +/-   ##
=======================================
  Coverage   43.30%   43.30%           
=======================================
  Files         186      186           
  Lines       23359    23359           
=======================================
  Hits        10116    10116           
  Misses      11797    11797           
  Partials     1446     1446           
Impacted Files Coverage Δ
util/settings/settings.go 48.10% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b44356...600b4eb. Read the comment docs.

@crenshaw-dev crenshaw-dev merged commit c59b8ea into argoproj:master Mar 28, 2022
@crenshaw-dev
Copy link
Collaborator

Thanks @danielhelfand!

wojtekidd pushed a commit to wojtekidd/argo-cd that referenced this pull request Apr 25, 2022
Signed-off-by: Daniel Helfand <helfand.4@gmail.com>
Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants