Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use new applicationset controller command #8940

Merged
merged 1 commit into from
Mar 30, 2022

Conversation

crenshaw-dev
Copy link
Member

@crenshaw-dev crenshaw-dev commented Mar 30, 2022

The command name changed and needs to be updated in the manifests.

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #8940 (e56577f) into master (8847a31) will increase coverage by 1.51%.
The diff coverage is 63.33%.

@@            Coverage Diff             @@
##           master    #8940      +/-   ##
==========================================
+ Coverage   43.40%   44.92%   +1.51%     
==========================================
  Files         186      212      +26     
  Lines       23373    25261    +1888     
==========================================
+ Hits        10145    11348    +1203     
- Misses      11779    12309     +530     
- Partials     1449     1604     +155     
Impacted Files Coverage Δ
applicationset/services/pull_request/fake.go 0.00% <0.00%> (ø)
applicationset/utils/createOrUpdate.go 0.00% <0.00%> (ø)
applicationset/utils/policy.go 0.00% <0.00%> (ø)
applicationset/services/pull_request/github.go 14.00% <14.00%> (ø)
...is/applicationset/v1alpha1/applicationset_types.go 34.69% <34.69%> (ø)
applicationset/generators/scm_provider.go 53.44% <53.44%> (ø)
applicationset/generators/pull_request.go 56.25% <56.25%> (ø)
...cationset/controllers/applicationset_controller.go 56.75% <56.75%> (ø)
applicationset/services/repo_service.go 57.14% <57.14%> (ø)
...licationset/generators/generator_spec_processor.go 57.57% <57.57%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e864652...e56577f. Read the comment docs.

@crenshaw-dev crenshaw-dev marked this pull request as ready for review March 30, 2022 15:45
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@alexmt alexmt merged commit 59672fb into argoproj:master Mar 30, 2022
@crenshaw-dev crenshaw-dev deleted the fix-appset-command branch March 30, 2022 18:05
wojtekidd pushed a commit to wojtekidd/argo-cd that referenced this pull request Apr 25, 2022
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants