fix: do not unset passCredentials when it's not specified (#9102) #9104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9104 +/- ##
==========================================
+ Coverage 45.51% 45.66% +0.15%
==========================================
Files 217 217
Lines 25663 25658 -5
==========================================
+ Hits 11680 11717 +37
+ Misses 12355 12316 -39
+ Partials 1628 1625 -3
Continue to review full report at Codecov.
|
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
… into fix-app-unset
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
|
i will review it in few hours @crenshaw-dev |
wojtekidd
pushed a commit
to wojtekidd/argo-cd
that referenced
this pull request
Apr 25, 2022
) (argoproj#9104) * fix: do not unset passCredentials when it's not specified (argoproj#9102) Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> * chore: codegen Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> * chore: more tests, no-update detection for kustomize Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> * chore: fix test Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9102
The main issue was that passCredentials was always unset.
The other issue was that some fields were being unset even if we didn't first check if they needed to be unset. So we were making an unnecessary API call.