Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

argocd app unset always unsets helm.passCredentials #9102

Closed
crenshaw-dev opened this issue Apr 14, 2022 · 0 comments · Fixed by #9104
Closed

argocd app unset always unsets helm.passCredentials #9102

crenshaw-dev opened this issue Apr 14, 2022 · 0 comments · Fixed by #9104
Labels
bug Something isn't working component:cli Affects the Argo CD CLI

Comments

@crenshaw-dev
Copy link
Member

Describe the bug

argocd app unset, when used with a Helm app, always unsets helm.passCredentials if that field is set to true.

To Reproduce

Create any Helm app. Set the source.helm.passCredentials field to true. Also set the values field to some string.

Then run these:

argocd app get guestbook -ojson | jq '.spec.source.helm.passCredentials'
argocd app unset guestbook --values-literal
argocd app get guestbook -ojson | jq '.spec.source.helm.passCredentials'

The first time you run get, passCredentials will be true. After resetting the values literal, it will be null (i.e. false).

Expected behavior

The command should not have reset that variable.

Version

CLI version 2.3.1.
@crenshaw-dev crenshaw-dev added bug Something isn't working component:cli Affects the Argo CD CLI labels Apr 14, 2022
@crenshaw-dev crenshaw-dev mentioned this issue Apr 14, 2022
Closed
crenshaw-dev added a commit to crenshaw-dev/argo-cd that referenced this issue Apr 14, 2022
@crenshaw-dev
fix: do not unset passCredentials when it's not specified (argoproj#9102
b7179e4 
)

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
@crenshaw-dev crenshaw-dev mentioned this issue Apr 14, 2022
Merged
pasha-codefresh pushed a commit that referenced this issue Apr 18, 2022
@crenshaw-dev
fix: do not unset passCredentials when it's not specified (#9102) (#9104
2738358 
)

* fix: do not unset passCredentials when it's not specified (#9102)

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

* chore: codegen

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

* chore: more tests, no-update detection for kustomize

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

* chore: fix test

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
wojtekidd pushed a commit to wojtekidd/argo-cd that referenced this issue Apr 25, 2022
@crenshaw-dev @wojtekidd
fix: do not unset passCredentials when it's not specified (argoproj#9102
3120a98 
) (argoproj#9104)

* fix: do not unset passCredentials when it's not specified (argoproj#9102)

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

* chore: codegen

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

* chore: more tests, no-update detection for kustomize

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>

* chore: fix test

Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Signed-off-by: wojtekidd <wojtek.cichon@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working component:cli Affects the Argo CD CLI
Projects
None yet
Milestone
No milestone
1 participant
@crenshaw-dev