chore(deps-dev): remove unused @testing-library/ deps
#569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agilgur5
added
type/dependencies
agilgur5
requested review from
crenshaw-dev,
terrytangyuan,
rbreeze,
tczhao and
isubasinghe
crenshaw-dev
requested changes
Aug 22, 2024
- they're not used in the repo
- I guess I missed these in my previous removals and assumed they were used or something
- there aren't that many tests in this repo either
- while `testing-library` is the preferred tool in the ecosystem these days, `enzyme` is still used in this repo
- potentially could be replaced by `testing-library`, but not necessarily worthwhile given the deprecated state of this repo
- also automatically reorder the `@types/uuid` dep
- happens automatically on a `yarn add` or `yarn remove`, I just left it out from previous removals as they were much larger and so it could be distracting
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
agilgur5
force-pushed
the
chore-remove-unused-testing-library
branch
from
fbdf536
to
aa04e18
Compare
|
Rebased it myself here and it's working for me locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
@testing-libraryand get no results other than the dep manifestsresolutions#534) and assumed they were used or somethingtesting-libraryis the preferred tool in the ecosystem these days,enzymeis still used in this repotesting-library(if no mounting etc is necessarily used), but not necessarily worthwhile given the deprecated state of this repo (argo-ui: future state of this repo #453)Modifications
remove
@testing-library/deps from thepackage.jsonandyarn.lockviayarn removealso automatically reorder the
@types/uuiddepyarn addoryarn remove, I just left it out from previous removals as they were much larger and so it could be distractingVerification
Build, lint, test, etc all still function fine as CI shows