Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When not specifying port for Postgres DB port is defaulting to 0 #4756

Closed
stefansedich opened this issue Dec 16, 2020 · 3 comments · Fixed by #4757
Closed

When not specifying port for Postgres DB port is defaulting to 0 #4756

stefansedich opened this issue Dec 16, 2020 · 3 comments · Fixed by #4757
Assignees
@alexec
Labels
type/bug type/regression Regression from previous behavior (a specific type of bug)
Milestone
v2.12

Comments

@stefansedich
Copy link
Contributor

Summary

It looks like since the changes in #4307 if you do not specify a port for your PG configuration it will now default to 0 since the port type has changed to an integer and the concatenation logic will append :0 to the connection string.

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
@alexec alexec added the type/regression Regression from previous behavior (a specific type of bug) label Dec 16, 2020
@alexec alexec self-assigned this Dec 16, 2020
alexec added a commit to alexec/argo-workflows that referenced this issue Dec 16, 2020
@alexec
fix(controller): Support default database port. Fixes argoproj#4756
b338560 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec added this to the v2.12 milestone Dec 16, 2020
@alexec alexec linked a pull request Dec 16, 2020 that will close this issue
fix(controller): Support default database port. Fixes #4756 #4757
Merged
1 task
@alexec
Copy link
Contributor

alexec commented Dec 16, 2020

Please can you test :fix-4756

@stefansedich
Copy link
Contributor Author

Thanks @alexec for the speedy fix, that LGTM.

alexec added a commit that referenced this issue Dec 17, 2020
@alexec
fix(controller): Support default database port. Fixes #4756 (#4757)
fbb4e8d 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@simster7 simster7 mentioned this issue Jan 4, 2021
Closed
21 tasks
simster7 pushed a commit that referenced this issue Jan 4, 2021
@alexec @simster7
fix(controller): Support default database port. Fixes #4756 (#4757)
a602798 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@simster7
Copy link
Member

simster7 commented Jan 5, 2021

Fix for this is out on https://github.com/argoproj/argo/releases/tag/v2.12.3

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexec alexec

Labels
type/bug type/regression Regression from previous behavior (a specific type of bug)
Projects
None yet
Milestone
v2.12
Development

Successfully merging a pull request may close this issue.

fix(controller): Support default database port. Fixes #4756 alexec/argo-workflows
3 participants
@stefansedich @simster7 @alexec