feat: Add operation configuration to gauge metric. Fixes #10662 #10774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: eduardodbr <eduardodbr@hotmail.com>
Signed-off-by: eduardodbr <eduardodbr@hotmail.com>
rohankmr414
reviewed
Mar 29, 2023
Signed-off-by: eduardodbr <eduardodbr@hotmail.com>
terrytangyuan
approved these changes
Apr 19, 2023
|
Could you resolve the conflicts? Thanks! |
Signed-off-by: eduardodbr <eduardodbr@hotmail.com>
5 tasks
JPZ13
pushed a commit
to pipekit/argo-workflows
that referenced
this pull request
Jul 4, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
first time contributing to Argo, I've read the contributing guidelines but let me know if something else is needed.
Prometheus Gauge interface allows to Set(), Add() and Sub() to the metric's current value. However, Argo workflows only accept setting a new value. This PR implements a new configuration field to the gauge metric called
operation. This field accepts three values:Add,Set, andSub. To avoid breaking changes, it usesSetby default if the field is not configured.Let me know what you think about the implementation. I can also add the field to the documentation examples.
Fixes #10662