feat: add chunk size argument to delete cli command #10813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Skånberg-Tippen <oliverskanbergtippen@gmail.com>
Signed-off-by: Oliver Skånberg-Tippen <oliverskanbergtippen@gmail.com>
terrytangyuan
approved these changes
Apr 6, 2023
JPZ13
pushed a commit
to pipekit/argo-workflows
that referenced
this pull request
Jul 4, 2023
Signed-off-by: Oliver Skånberg-Tippen <oliverskanbergtippen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
argo listCLI command accepts an--chunk-size nargument, but theargo deletecommand does not. In our case, this was problematic because the large number of old workflows we had was causing unbounded list queries to fail, and the sensible remedy (deleting old workflows) was not possible because (for example)argo delete --since 30dcould not be chunked in the same way that listing could.This PR adds a
--query-chunk-size nargument toargo delete, which is applied when the command is fetching the workflows it will delete. The namequery-chunk-sizeis different from the list command optionchunk-sizeto avoid the implication that it will delete according to the specified chunk - but please suggest a better name if you have one.The flag is passed directly to
listWorkflowsso follows the same code path as thelistcommand.