fix(docs): exclude docs/requirements.txt from docs build
#12466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- it's currently being hosted on https://argo-workflows.readthedocs.io/en/latest/requirements.txt - this is a new file that we have to exclude now - specify `/` in front which means only the ones in the `docs/` directory - see https://www.mkdocs.org/user-guide/configuration/#exclude_docs - notably, the in-line comments that the docs have don't actually work, it seems to cause the whole `exclude_docs` block to be ignored as a result follow-up to e921056 Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
agilgur5
added
area/docs
jmeridth
approved these changes
Jan 4, 2024
terrytangyuan
approved these changes
Jan 5, 2024
jmeridth
added a commit
to jmeridth/argo-workflows
that referenced
this pull request
Jan 5, 2024
Includes fixes from argoproj#12464, argoproj#12466, argoproj#12465 - all authored by @agilgur5 Includes files list from argoproj#12414 description Signed-off-by: jmeridth <jmeridth@gmail.com> Co-authored-by: Anton Gilgur <agilgur5@gmail.com>
jmeridth
added a commit
to jmeridth/argo-workflows
that referenced
this pull request
Jan 5, 2024
Includes fixes from argoproj#12464, argoproj#12466, argoproj#12465 - all authored by @agilgur5 Includes files list from argoproj#12414 description Signed-off-by: jmeridth <jmeridth@gmail.com> Co-authored-by: Anton Gilgur <agilgur5@gmail.com>
jmeridth
added a commit
to jmeridth/argo-workflows
that referenced
this pull request
Jan 5, 2024
Includes fixes from argoproj#12464, argoproj#12466, argoproj#12465 - all authored by @agilgur5 Includes files list from argoproj#12414 description Signed-off-by: jmeridth <jmeridth@gmail.com> Co-authored-by: Anton Gilgur <agilgur5@gmail.com>
7 tasks
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Feb 27, 2024
…12466) Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Feb 27, 2024
…12466) Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Feb 27, 2024
…12466) Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Feb 28, 2024
…12466) Signed-off-by: Anton Gilgur <agilgur5@gmail.com> Signed-off-by: Isitha Subasinghe <isubasinghe@student.unimelb.edu.au>
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Mar 12, 2024
…12466) Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
docs/requirements.txtis currently being incorrectly hosted on https://argo-workflows.readthedocs.io/en/latest/requirements.txtfollow-up to #12360
Modifications
/requirements.txttoexclude_docsinmkdocs.yml/in front which means only the ones in thedocs/directoryexclude_docsblock to be ignored as a resultVerification
make docsopen site/requirements.txtwhich no longer works (it did prior to this change)