Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Document cost optimizations. Fixes #1139 #2972

Merged
merged 33 commits into from May 28, 2020
Merged

Conversation

alexec
Copy link
Contributor

@alexec alexec commented May 7, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

See #2934,
Fixes #1139

@alexec alexec changed the title docs: Document cost optimisations. docs: Document cost optimizations. Fixes #1139 May 7, 2020
@alexec alexec requested a review from jessesuen May 8, 2020 18:07
@alexec
Copy link
Contributor Author

alexec commented May 8, 2020

@jessesuen would you like to make any suggestions or edits please?

@alexec alexec marked this pull request as ready for review May 8, 2020 18:07
@alexec
Copy link
Contributor Author

alexec commented May 13, 2020

@jessesuen do you think you might be able to review this week please?

@alexec
Copy link
Contributor Author

alexec commented May 22, 2020

@sarabala1979 @jessesuen this is now two weeks old. Could I please chase for a code review?

@sonarcloud
Copy link

sonarcloud bot commented May 27, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@jessesuen jessesuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional approval with some tweaks to some of the recommendations.

docs/cost-optimisation.md Outdated Show resolved Hide resolved
docs/cost-optimisation.md Show resolved Hide resolved

> Suitable if you have a workflow that passes a lot of artifacts within itself.

Copying artifacts to and from storage outside of a cluster can be expensive. You can use a volume claim template to mount a volume that is attached to each step within the cluster
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suitable if you have a workflow that passes a lot of artifacts within itself.

Theres so many variables in this that it's hard to make any recommendation other than "consider doing this depending on this."

Volumes vs. VolumeClaimTemplates vs. Artifacts is highly dependent on what their artifact storage provider is vs. what volume they are using. For example, I believe it is more expensive to allocate and delete new EBS volumes every workflow using the PVC feature, than it is to upload and download some small files to S3.

On the other hand if they are using a NFS volume shared between all their workflows with large artifacts, that might be cheaper than the data transfer and storage costs of S3.

Lets reword this so we outline the variables to consider when choosing when to use artifacts vs. volumes:

  1. data transfer costs (upload/download vs. copying)
  2. data storage costs (s3 vs. volume)
  3. requirement for parallel access to data (NFS vs. EBS vs. artifact)

@alexec alexec merged commit 2d9a74d into argoproj:master May 28, 2020
@alexec alexec deleted the docs-cost branch May 28, 2020 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory Configurations for Argo Operator
5 participants