Attempts in the name of the screenshot on Cypress SDK

[gregberge]

A client have screenshots with "(attempt n)" in their name, so it creates flakiness (remove / added) and does not compare screenshot. We have to:

• Investigate when does Cypress do that
• Be sure that the screenshot name is consistent if taken with argosScreenshot method

      on('after:screenshot', (details) => {
        // Get the base filename without extension
        const baseName = path.basename(
          details.path,
          path.extname(details.path),
        );

        // Remove attempt from the filename
        const newBaseName = baseName.replace(/ \(attempt \d+\)/, '');

        // Construct a new path with the original file extension
        const newPath = path.join(
          path.dirname(details.path),
          newBaseName + path.extname(details.path),
        );

        return new Promise((resolve, reject) => {
          fs.rename(details.path, newPath, (err) => {
            if (err) {
              return reject(err);
            }

            resolve({ path: newPath });
          });
        });
      });

[jsfez]

For you information, the issue exist with Playwright too. But the wording is not "attempt" but "retry"

[gregberge]

Done in #115