Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are there plans to switch to ES module? #81

Open
flensrocker opened this issue Sep 15, 2020 · 15 comments
Open

Are there plans to switch to ES module? #81

flensrocker opened this issue Sep 15, 2020 · 15 comments

Comments

@flensrocker
Copy link

Rewriting iban.js is not that hard, but I fail to migrate the tests...

@sander1095
Copy link

Hello! Any updates on this? It'd be great if this was an ES Module

@flensrocker
Copy link
Author

If you can help to rewrite the test, that would be great. I don't have much experience with them...

@sander1095
Copy link

I have mailed @arhs about the status of this project. I also ping @LaurentVB because they have done the latest work on this project.

If this project is unmaintained I do not see a reason to write tests; it'd be better to fork this project instead. There are a lot of important issues and PR's open and currently I am unsure if your (great!) PR will be merged.

@Qsaws
Copy link

Qsaws commented Mar 4, 2021

Same request here, did you get a response from them @sander1095 ?

@sander1095
Copy link

Nope, no response sadly

@Qsaws
Copy link

Qsaws commented Mar 5, 2021

Nope, no response sadly

I switched to this package https://www.npmjs.com/package/ibantools

@flensrocker
Copy link
Author

If someone has time to rewrite the tests, we might create a forked package. The last commit is over a year ago. I don't know if this source is maintained any more.

@itoche
Copy link
Contributor

itoche commented Mar 5, 2021

Hi all,
I'm checking if someone at @arhs will take over the maintenance of this package. I'll let you know in the next days if we continue to maintain it or not.

@itoche
Copy link
Contributor

itoche commented Mar 26, 2021

Sadly, the lib will not be maintained anymore.

@flensrocker
Copy link
Author

Thank you for the response.
Not supporting it anymore is ok, the source is MIT, so I can fork it and make my own module.

@sander1095
Copy link

@flensrocker I would just use ibantools like @Qsaws suggested. I switched to it and works great!

@sander1095
Copy link

I have created #88 and #89 to finalize the state change of this repo to "unmaintained"

@flensrocker
Copy link
Author

Thank you, I will take a look at ibantools.

@tjcampbell
Copy link

Careful pointing people to ibantools, it has a very restrictive license (MPL-2.0) compared to this package

@Clindbergh
Copy link

Careful pointing people to ibantools, it has a very restrictive license (MPL-2.0) compared to this package

ibantools can now be used under MIT too.

This work is dual-licensed under MIT and MPL-2.0. You can choose between one of them if you use this work.
https://github.com/Simplify/ibantools/blob/16942b69e251304638559a73848b801365e0040e/README.md?plain=1#L111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants