Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the URL parsing for special characters. #3028

Closed
zelawat08 opened this issue Aug 6, 2024 · 2 comments
Closed

Fix the URL parsing for special characters. #3028

zelawat08 opened this issue Aug 6, 2024 · 2 comments

Comments

@zelawat08
Copy link

Outline of This Issue

Encountered error when using special characters in the password.

Goal

  • Modify the parsing method to add URL escape method.

Reference

u, err := url.Parse(s)

@a8m
Copy link
Member

a8m commented Aug 6, 2024

Hey @zelawat08,

You can use the urlescape function in atlas.hcl. See: Please see: https://atlasgo.io/concepts/url#non-alphanumeric-characters


For more info, please see @rotemtam comment on this subject:

As the command accepts a URL, the standard way for dealing with odd characters is using URL encoding, see IETF RFC 1738, (see section 2.2) which defines URLs formally. I don't think Atlas should encode the URL for the user as this is a one-time operation (e.g doesn't change unless the password itself changes).

@a8m a8m closed this as completed Aug 6, 2024
@giautm
Copy link
Member

giautm commented Aug 6, 2024

You need encode the password before build the URL for atlas

https://atlasgo.io/concepts/url#non-alphanumeric-characters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants