The fix for issue #192 broke service_managed false #197
Labels
bug
Something isn't working
Comments
|
Good point, I should probably only refresh the service if it's being managed by Puppet. In fact, since this is in the config class, it should automatically notify the service if it's enabled anyway. I'll open a PR and also add an acceptance test with this setting to make sure this doesn't regress 😄 |
|
Perfect, thanks :) |
petems
added a commit
to petems/puppet-redis
that referenced
this issue
May 5, 2017
* If the redis service is unmanaged, like so: ``` redis::managed_by_cluster_manager": true redis::service_manage": false redis::notify_service": false ``` then you get a compilation failure as it tries to look for the redis service to notify: ``` But now an 'include ::redis' gives me: Error: Could not find dependent Service[redis] for Augeas[Systemd redis ulimit] at /etc/puppet/modules/redis/manifests/ulimit.pp:44 ``` * In fact, we don't need any service notification in the redis::ulimit class, as it's already in the redis::config class, which notifies the service class anyways * Adds spec for this use-case to avoid regression Closes voxpupuli#197
petems
added a commit
that referenced
this issue
May 5, 2017
* If the redis service is unmanaged, like so: ``` redis::managed_by_cluster_manager": true redis::service_manage": false redis::notify_service": false ``` then you get a compilation failure as it tries to look for the redis service to notify: ``` But now an 'include ::redis' gives me: Error: Could not find dependent Service[redis] for Augeas[Systemd redis ulimit] at /etc/puppet/modules/redis/manifests/ulimit.pp:44 ``` * In fact, we don't need any service notification in the redis::ulimit class, as it's already in the redis::config class, which notifies the service class anyways * Adds spec for this use-case to avoid regression Closes #197
cegeka-jenkins
pushed a commit
to cegeka/puppet-redis
that referenced
this issue
Feb 16, 2021
* If the redis service is unmanaged, like so: ``` redis::managed_by_cluster_manager": true redis::service_manage": false redis::notify_service": false ``` then you get a compilation failure as it tries to look for the redis service to notify: ``` But now an 'include ::redis' gives me: Error: Could not find dependent Service[redis] for Augeas[Systemd redis ulimit] at /etc/puppet/modules/redis/manifests/ulimit.pp:44 ``` * In fact, we don't need any service notification in the redis::ulimit class, as it's already in the redis::config class, which notifies the service class anyways * Adds spec for this use-case to avoid regression Closes voxpupuli#197
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have the following hiera values:
redis::managed_by_cluster_manager": true
redis::service_manage": false
redis::notify_service": false
But now an 'include ::redis' gives me:
Error: Could not find dependent Service[redis] for Augeas[Systemd redis ulimit] at /etc/puppet/modules/redis/manifests/ulimit.pp:44
Did you mean to make https://github.com/arioch/puppet-redis/blob/master/manifests/ulimit.pp#L31 an 'elsif' and not an 'if'?
The text was updated successfully, but these errors were encountered: