Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue in the "Switch" control and "Number" control #1648

Closed
pubudu7 opened this issue Nov 18, 2017 · 4 comments
Closed

Issue in the "Switch" control and "Number" control #1648

pubudu7 opened this issue Nov 18, 2017 · 4 comments
Milestone

Comments

@pubudu7
Copy link

pubudu7 commented Nov 18, 2017

Hi,

Issue description:

I was using 2.3.7 version on my theme. And I updated it to 3.0.16 because of the color controls were not working with WordPress 4.9. But the Swich doesn't seem to be styled properly. Please compare the two screenshots I have provided.

  • 2.3.7 Version -

2 3 7

  • 3.0.15 Version -

3 0 15

Version used:

I used the development branch and it did not work. Also I encountered that number control uses two plus minus buttons instead of up down arrows. And plus minus buttons also not working. They are not saving.

Using theme_mods or options?

I am using theme mods.

Thank You.

aristath added a commit that referenced this issue Nov 18, 2017
@aristath
Copy link
Contributor

Fixed the number control issue. Buttons now work.
I can confirm the issue with the switch controls as well, but that's a minor CSS issue so nothing that will break anyone's site. It can wait for the next release since 3.0.16 has to go out later tonight to fix a couple of inconsistencies with WP 4.9

@aristath aristath added this to the 3.0.17 milestone Nov 18, 2017
@aristath
Copy link
Contributor

Moved this one to the 3.0.17 milestone, I'll examine the switches css after 3.0.16 is out.

@pubudu7
Copy link
Author

pubudu7 commented Nov 19, 2017

Great..! Thank you.

@aristath aristath modified the milestones: 3.0.17, 3.0.19 Dec 6, 2017
@aristath aristath modified the milestones: 3.0.19, Future Release Dec 13, 2017
@DannyCooper
Copy link
Contributor

Switches tested and they are displaying correctly in 3.0.43.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants