Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Background control type #1808

Closed
anthonyryanrusso opened this issue Feb 19, 2018 · 4 comments
Closed

Background control type #1808

anthonyryanrusso opened this issue Feb 19, 2018 · 4 comments
Milestone
3.0.26

Comments

@anthonyryanrusso
Copy link

anthonyryanrusso commented Feb 19, 2018 •
edited
Loading

I think the background control type should output the "background-color" property as just "background" if there is no image. The reason I say this is if you give the user a choice between two options "regular/gradient" and the gradient uses the "background" or "background-image" property then it will override "background-color" on hover.
@anthonyryanrusso
Copy link
Author

@aristath Any feedback on this?

@aristath
Copy link
Contributor

aristath commented Mar 5, 2018

I don't understand the "2 options" part, could you please elaborate?

@anthonyryanrusso
Copy link
Author

anthonyryanrusso commented Mar 5, 2018 •
edited
Loading

No problem. Here is a video showing that if social media icon anchors are set as a gradient which uses "background-image" and you set the anchor hover as a regular "background-color" it doesn't do anything since "background-image" is superior to "background-color".

E.g. http://nimb.ws/d6fi9x

@aristath
Copy link
Contributor

Pushed a fix for this.

@aristath aristath added this to the 3.0.26 milestone Mar 17, 2018
aristath added a commit that referenced this issue Mar 17, 2018
@aristath
Merge branch 'develop' into postMessage-refactor
f0182ea 
* develop: (73 commits)
  fixes #1730
  fixes #1830
  GDPR: Load webfont-loader locally
  Update fonts
  fixes #1834
  Apply WordPress Coding Standards
  Update kirki-helper-class.md
  see #1797
  cleanup unused vars
  See #1807
  Additional fix for #1809
  fixes #1828
  fixes #1808
  fix #1814
  fix #1797
  fixes #1809
  Update sortable.md
  fixes #1787
  update webfonts & grunt
  changelog
  ...

# Conflicts:
#	modules/postmessage/class-kirki-modules-postmessage.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.26
Development

No branches or pull requests
2 participants
@aristath @anthonyryanrusso